Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing fancybox plugin in new theme pages #19796

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Missing fancybox plugin in new theme pages #19796

merged 1 commit into from
Jun 16, 2020

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Jun 16, 2020 •
edited by eternoendless
Loading

Questions Answers
Branch? 1.7.7.x
Description? We are using fancybox on the new-theme, but never require it on webpack nor in the HTML.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Not sure QA is needed here

Go to /admin-dev/index.php/sell/orders/orders/6/view
Before:
image

After:
image

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Jun 16, 2020
@PierreRambaud PierreRambaud requested a review from a team as a code owner June 16, 2020 13:46
@prestonBot prestonBot added 1.7.7.x Branch Bug Type: Bug labels Jun 16, 2020
@Progi1984
Copy link
Member

Always need @PrestaShop/qa-functional <3

@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Jun 16, 2020
@SD1982 SD1982 self-assigned this Jun 16, 2020
@SD1982
Copy link
Contributor

SD1982 commented Jun 16, 2020

LGTM Thanks @PierreRambaud !

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 16, 2020
@matks matks merged commit ecd910c into PrestaShop:1.7.7.x Jun 16, 2020
@matks
Copy link
Contributor

matks commented Jun 16, 2020

Thank you @PierreRambaud

@matks matks mentioned this pull request Jun 16, 2020
Closed
@PierreRambaud PierreRambaud deleted the fancybox branch June 16, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@jolelievre jolelievre jolelievre approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees

@SD1982 SD1982

Labels
1.7.7.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.
7 participants
@PierreRambaud @Progi1984 @SD1982 @matks @jolelievre @NeOMakinG @prestonBot