Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property display_footer is a boolean #20141

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Property display_footer is a boolean #20141

merged 1 commit into from
Jul 13, 2020

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Jul 10, 2020 •
edited by eternoendless
Loading

Questions Answers
Branch? develop
Description? Thanks phpstan for the report.29 Property ControllerCore::$display_footer (string) does not accept false.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? No need QA.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from a team as a code owner July 10, 2020 14:47
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Jul 10, 2020
@NeOMakinG NeOMakinG added the QA ✔️ Status: check done, code approved label Jul 13, 2020
@NeOMakinG NeOMakinG merged commit 2f651a7 into PrestaShop:develop Jul 13, 2020
@PierreRambaud PierreRambaud deleted the phpdoc branch July 13, 2020 12:23
@PierreRambaud PierreRambaud added this to the 1.7.8.0 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiix atomiix atomiix approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@PierreRambaud @atomiix @NeOMakinG @prestonBot