Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tables upgrade lines related to gamification module #20192

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Remove tables upgrade lines related to gamification module #20192

merged 1 commit into from
Jul 16, 2020

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Jul 16, 2020 •
edited by eternoendless
Loading

Questions Answers
Branch? 1.7.7.x
Description? Remove sql related to gamification module.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #20179
How to test? Run an upgrade to the 1.7.7.x branch.

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Jul 16, 2020
@PierreRambaud PierreRambaud requested a review from a team as a code owner July 16, 2020 12:23
@prestonBot prestonBot added 1.7.7.x Branch Bug Type: Bug labels Jul 16, 2020
@Progi1984 Progi1984 linked an issue Jul 16, 2020 that may be closed by this pull request
Sql error on autoupgrade on ps_condition table #20179
Closed
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Jul 16, 2020
@sarahdib sarahdib self-assigned this Jul 16, 2020
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 16, 2020
@PierreRambaud PierreRambaud merged commit 657984c into PrestaShop:1.7.7.x Jul 16, 2020
@PierreRambaud PierreRambaud deleted the fix/20179 branch July 16, 2020 13:38
@Progi1984 Progi1984 mentioned this pull request Jul 17, 2020
Closed
@rblaurin rblaurin mentioned this pull request Jul 19, 2020
Closed
@jf-viguier
Copy link
Contributor

Thanks @PierreRambaud for the fix.
Do you means that sql encoding change should be in the module ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

Assignees

@sarahdib sarahdib

Labels
1.7.7.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

Sql error on autoupgrade on ps_condition table
6 participants
@PierreRambaud @jf-viguier @Progi1984 @matks @sarahdib @prestonBot