Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TinyMCE error on product page #20451

Merged
merged 2 commits into from
Aug 13, 2020

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Aug 4, 2020

Questions Answers
Branch? 1.7.7.x
Description? There was an error on the product page
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fix? Fixes #20484
How to test? Build assets (cd admin-dev/themes/default && npm i && npm run build)
Go on "create product" page, open the console, should have no errors related to tinyMCE (on Chrome), also the product page experience/work should be as fine as before, specially with tinyMCE fields

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from a team as a code owner August 4, 2020 12:46
@prestonBot prestonBot added 1.7.7.x Branch Bug Type: Bug labels Aug 4, 2020
Progi1984
Progi1984 previously approved these changes Aug 4, 2020
@Progi1984 Progi1984 linked an issue Aug 4, 2020 that may be closed by this pull request
4 tasks
@boubkerbribri boubkerbribri mentioned this pull request Aug 4, 2020
4 tasks
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Aug 4, 2020
@Progi1984 Progi1984 changed the title Fix tinymce error on product page Fix TinyMCE error on product page Aug 4, 2020
matks
matks previously approved these changes Aug 6, 2020
@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Aug 6, 2020
@khouloudbelguith khouloudbelguith self-assigned this Aug 6, 2020
@khouloudbelguith
Copy link
Contributor

Hi @NeOMakinG,

It is ok

Before:

image

After
image

But I found a difference comparing 1.7.7.x
With PR
Add a new product, click on the Source code of the Summary and Description => it is empty
image

Without PR, I have this
image

Also, for the demo products, there are differences
With PR
image

Without PR, I have this
image

Thanks!

@khouloudbelguith khouloudbelguith added Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Aug 6, 2020
@NeOMakinG
Copy link
Author

Hey @khouloudbelguith,

I can't manage to reproduce it, maybe you added a space between branch switches ? I looks not related to what I touched on this PR :/

@Progi1984 Progi1984 linked an issue Aug 6, 2020 that may be closed by this pull request
@Progi1984 Progi1984 removed a link to an issue Aug 6, 2020
4 tasks
@matks
Copy link
Contributor

matks commented Aug 7, 2020

Hi !

Maybe something was changed recently on 1.7.7.x 🤔 because

  • on 1.7.7.x I dont see the tinyMCE errors even though I dont checkout the branch for this PR
  • on 1.7.7.x the "source code" for "summary" is empty even though I dont checkout the branch for this PR

@khouloudbelguith Can you please check again ?

@NeOMakinG
Copy link
Author

@matks did you try when you'r on a "Create product" page ? The error in the issue was on this page

(Just changed the description for this, sorry :P )

@matks
Copy link
Contributor

matks commented Aug 7, 2020

@matks did you try when you'r on a "Create product" page ? The error in the issue was on this page

(Just changed the description for this, sorry :P )

Yes, on "Create a product". I see no error in Console.

Which is weird as I remember seeing them 😅

@NeOMakinG
Copy link
Author

Also, did you build assets? (Trying to search why ^^)

@matks
Copy link
Contributor

matks commented Aug 10, 2020

@matthieu-rolland does not see the issue neither.

There is something we are missing. Something related to our environments and how we run PrestaShop.

@NeOMakinG
Copy link
Author

Found it, test it in low connection mode :

image

@khouloudbelguith
Copy link
Contributor

Hi @NeOMakinG,

Hey @khouloudbelguith,

I can't manage to reproduce it, maybe you added a space between branch switches ? I looks not related to what I touched on this PR :/

I tried with a new shop => the same issue reproduced.
I'm using this command
git prc origin 20451 1.7.7.x

Thanks!

@NeOMakinG
Copy link
Author

Hey @khouloudbelguith, thanks for testing

Which issue are you talking about ? The error in console, or the content of tinymce inputs ?

Thanks

@khouloudbelguith
Copy link
Contributor

Hi @NeOMakinG,

This issue:

But I found a difference comparing 1.7.7.x
With PR
Add a new product, click on the Source code of the Summary and Description => it is empty
image
Without PR, I have this
image
Also, for the demo products, there are differences
With PR
image
Without PR, I have this
image

Thanks!

@PierreRambaud
Copy link
Contributor

Hi @NeOMakinG,

This issue:

But I found a difference comparing 1.7.7.x
With PR
Add a new product, click on the Source code of the Summary and Description => it is empty
image
Without PR, I have this
image
Also, for the demo products, there are differences
With PR
image
Without PR, I have this
image

Thanks!

@NeOMakinG @khouloudbelguith The div with display has nothing to do here since the it's not in the content. The value With the pull request is the good one. I also manage to reproduce the issue and everything is ok with this PR :)

Co-authored-by: GoT <PierreRambaud@users.noreply.github.com>
@NeOMakinG NeOMakinG dismissed stale reviews from matks and Progi1984 via ffa79fd August 12, 2020 14:31
@NeOMakinG NeOMakinG requested a review from a team August 12, 2020 14:31
@PierreRambaud PierreRambaud added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback labels Aug 12, 2020
@khouloudbelguith
Copy link
Contributor

Hi @NeOMakinG, @PierreRambaud,

It is ok ✔️
image

Thanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Aug 13, 2020
@NeOMakinG
Copy link
Author

So @PierreRambaud, what about the strange div ? Do you have it locally ? I don't have it at all, but khouloud got it (I doubt this is linked to this PR, but let's be sure before merging)

@PierreRambaud
Copy link
Contributor

So @PierreRambaud, what about the strange div ? Do you have it locally ? I don't have it at all, but khouloud got it (I doubt this is linked to this PR, but let's be sure before merging)

Without the PR I don't have the empty div, it's maybe something added by a chrome extension 🤔 Anyway, we can merge this one :)

@PierreRambaud PierreRambaud merged commit 3cc11d1 into PrestaShop:1.7.7.x Aug 13, 2020
@PierreRambaud
Copy link
Contributor

Thank @NeOMakinG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.7.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TinyMCE error on product page
6 participants