-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TinyMCE error on product page #20451
Fix TinyMCE error on product page #20451
Conversation
Hi @NeOMakinG, It is ok Before: But I found a difference comparing 1.7.7.x Also, for the demo products, there are differences Thanks! |
Hey @khouloudbelguith, I can't manage to reproduce it, maybe you added a space between branch switches ? I looks not related to what I touched on this PR :/ |
Hi ! Maybe something was changed recently on
@khouloudbelguith Can you please check again ? |
@matks did you try when you'r on a "Create product" page ? The error in the issue was on this page (Just changed the description for this, sorry :P ) |
Yes, on "Create a product". I see no error in Console. Which is weird as I remember seeing them 😅 |
Also, did you build assets? (Trying to search why ^^) |
@matthieu-rolland does not see the issue neither. There is something we are missing. Something related to our environments and how we run PrestaShop. |
Hi @NeOMakinG,
I tried with a new shop => the same issue reproduced. Thanks! |
Hey @khouloudbelguith, thanks for testing Which issue are you talking about ? The error in console, or the content of tinymce inputs ? Thanks |
Hi @NeOMakinG, This issue:
Thanks! |
@NeOMakinG @khouloudbelguith The div with display has nothing to do here since the it's not in the content. The value With the pull request is the good one. I also manage to reproduce the issue and everything is ok with this PR :) |
Co-authored-by: GoT <PierreRambaud@users.noreply.github.com>
Hi @NeOMakinG, @PierreRambaud, Thanks! |
So @PierreRambaud, what about the strange div ? Do you have it locally ? I don't have it at all, but khouloud got it (I doubt this is linked to this PR, but let's be sure before merging) |
Without the PR I don't have the empty div, it's maybe something added by a chrome extension 🤔 Anyway, we can merge this one :) |
Thank @NeOMakinG |
cd admin-dev/themes/default && npm i && npm run build
)Go on "create product" page, open the console, should have no errors related to tinyMCE (on Chrome), also the product page experience/work should be as fine as before, specially with tinyMCE fields
This change is