Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symfony cache clear #21429

Merged
merged 3 commits into from
Oct 14, 2020

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Oct 13, 2020

Questions Answers
Branch? develop
Description? Remove pools:prune command which does not clear the container enough Launch the command only on process shutdown to avoid error during process and memory overloading In previous fix the Clear cache command was not executed correctly, the input arguments were not correctly set (use '--no-warmup' => true, not '--no-warmup',)
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #21413
How to test? See issue to reproduce issue regarding ps_linklist routing problem Also try to uninstall, clear cache and reinstall productcomments to check Doctrine is correctly initialized

This change is Reviewable

@jolelievre jolelievre requested a review from a team as a code owner October 13, 2020 17:13
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Oct 13, 2020
@jolelievre jolelievre added this to the 1.7.8.0 milestone Oct 13, 2020
@jolelievre
Copy link
Contributor Author

Note: there was only one thing I didn't manage to handle perfectly When you manually remove the cache folder before re-installing the module The install process happens correctly however the Configure button is not visible

However this only happens when you remove the cache manually, when you uninstall the module from the BO the cache is correctly cleared (no info regarding ps_linklist routing can be found in the cache folder), and when you reinstall it the cache is correctly rebuilt with appropriate routing infos And the Configure button is correctly displayed

Since removing the cache manually is not supposed to be done, and since it's not blocking anyway I think this "glitch" is acceptable

@prestashop-issue-bot prestashop-issue-bot bot added the WIP Status: Work In Progress label Oct 13, 2020
@jolelievre jolelievre added Waiting for dev Status: action required, waiting for tech feedback and removed WIP Status: Work In Progress labels Oct 13, 2020
@atomiix atomiix added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for dev Status: action required, waiting for tech feedback labels Oct 14, 2020
@ngodefroy ngodefroy self-assigned this Oct 14, 2020
@ngodefroy
Copy link

Hello @jolelievre

What I tested:

Go to Module Manager
Uninstall ps_linklist
Remove the cache manually: rm -fR ./var/cache/*
Go to Module Catalog
Refresh the page so that the menu is updated (this should be handled by MBO)
Click on Design > Linkwidget is deleted

Same test without the removal of cache manually

uninstalled Product comment module
Cleared cache (manually & not)
Reinstalled it
Changed configuration into module
Saved

TEST OK

Thank you

@ngodefroy ngodefroy added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 14, 2020
@Progi1984 Progi1984 merged commit 996cfa7 into PrestaShop:develop Oct 14, 2020
@Progi1984
Copy link
Member

Thanks @jolelievre & @ngodefroy

@jolelievre jolelievre deleted the fix-symfony-cache-clear branch February 2, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache clear issue after optimization
6 participants