Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INSTALL.txt #21453

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

taoufiqaitali
Copy link
Contributor

@taoufiqaitali taoufiqaitali commented Oct 14, 2020

Questions Answers
Branch? develop
Description? file is not up to date
Type? refacto
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

This change is Reviewable

file is not up to date
@taoufiqaitali taoufiqaitali requested a review from a team as a code owner October 14, 2020 16:46
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Oct 14, 2020
@matthieu-rolland matthieu-rolland merged commit 0a5611f into PrestaShop:develop Oct 15, 2020
@matthieu-rolland
Copy link
Contributor

thanks for your contribution @taoufiqaitali !

@taoufiqaitali taoufiqaitali deleted the patch-3 branch October 15, 2020 08:25
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Refactoring Type: Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants