Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help text not displayed in form_row #21623

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Oct 26, 2020

Questions Answers
Branch? develop
Description? Help text are not displayed on twig forms
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #19540.
How to test? See issues, download the module and check help labels, also try to see if it doesn't break anything on migrated BO pages form

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from a team as a code owner October 26, 2020 16:45
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Oct 26, 2020
@NeOMakinG NeOMakinG changed the title Add help test to form_row Fix help text not displayed in form_row Oct 26, 2020
@atomiix atomiix closed this Oct 27, 2020
@atomiix atomiix reopened this Oct 27, 2020
atomiix
atomiix previously approved these changes Oct 27, 2020
Progi1984
Progi1984 previously approved these changes Oct 27, 2020
@NeOMakinG NeOMakinG added the Waiting for QA Status: action required, waiting for test feedback label Oct 28, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Nov 2, 2020
PierreRambaud
PierreRambaud previously approved these changes Nov 10, 2020
@SD1982 SD1982 assigned SD1982 and unassigned SD1982 Nov 12, 2020
@khouloudbelguith khouloudbelguith self-assigned this Nov 16, 2020
@khouloudbelguith
Copy link
Contributor

Hi @NeOMakinG,

I used this module.
In the BO > Module configuration page > Basic Settings > Only two files are fixed

  1. CHECKBOFORM_YESANDNO
    image
  2. CHECKBOFORM_IPADDRESS
    image

But other fields, the Tooltip is not displayed.
For example: "Category tree"
image

I checked the code line

        $builder
            ->add('CHECKBOFORM_CATEGORYTREE', CategoryChoiceTreeType::class, [
                'label' => $this->translator->trans('Category tree', [], 'Module.Checkboform.Admin'),
                'help' => $this->translator->trans('Help me I\'m famous !', [], 'Module.Checkboform.Admin'),
                'multiple' => true,
                'label_attr' => [
                    'class' => 'pr-3',
                    'popover' => $this->translator->trans('Tooltip me I\'m famous !', [], 'Module.Checkboform.Admin'),
                ],
            ]);

Thanks!

@khouloudbelguith khouloudbelguith added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 16, 2020
atomiix
atomiix previously approved these changes Nov 19, 2020
@Progi1984 Progi1984 removed the Waiting for author Status: action required, waiting for author feedback label Nov 19, 2020
Progi1984
Progi1984 previously approved these changes Nov 19, 2020
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Nov 19, 2020
@NeOMakinG NeOMakinG added WIP Status: Work In Progress and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 19, 2020
@NeOMakinG NeOMakinG removed the WIP Status: Work In Progress label Jan 4, 2021
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jan 5, 2021
@khouloudbelguith
Copy link
Contributor

Hi @NeOMakinG,

It is ok ✔️
image

I checked some migrated page wth tooltip => ok (Administration page)
image
I checked other page with help option => ok
image

Thanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jan 6, 2021
@Progi1984 Progi1984 merged commit 74c9aa6 into PrestaShop:develop Jan 6, 2021
@Progi1984
Copy link
Member

Thanks @NeOMakinG & @khouloudbelguith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Type help and popover tooltip not display properly
7 participants