-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix help text not displayed in form_row #21623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeOMakinG
changed the title
Add help test to form_row
Fix help text not displayed in form_row
Oct 26, 2020
atomiix
previously approved these changes
Oct 27, 2020
Progi1984
previously approved these changes
Oct 27, 2020
NeOMakinG
added
the
Waiting for QA
Status: action required, waiting for test feedback
label
Oct 28, 2020
PierreRambaud
previously approved these changes
Nov 10, 2020
Hi @NeOMakinG, I used this module. But other fields, the Tooltip is not displayed. I checked the code line $builder
->add('CHECKBOFORM_CATEGORYTREE', CategoryChoiceTreeType::class, [
'label' => $this->translator->trans('Category tree', [], 'Module.Checkboform.Admin'),
'help' => $this->translator->trans('Help me I\'m famous !', [], 'Module.Checkboform.Admin'),
'multiple' => true,
'label_attr' => [
'class' => 'pr-3',
'popover' => $this->translator->trans('Tooltip me I\'m famous !', [], 'Module.Checkboform.Admin'),
],
]); Thanks! |
khouloudbelguith
added
Waiting for author
Status: action required, waiting for author feedback
and removed
Waiting for QA
Status: action required, waiting for test feedback
labels
Nov 16, 2020
NeOMakinG
dismissed stale reviews from PierreRambaud, Progi1984, and atomiix
via
November 18, 2020 14:52
dd1daf2
NeOMakinG
force-pushed
the
issue19540
branch
from
November 18, 2020 14:52
aebf6f1
to
dd1daf2
Compare
atomiix
previously approved these changes
Nov 19, 2020
Progi1984
removed
the
Waiting for author
Status: action required, waiting for author feedback
label
Nov 19, 2020
Progi1984
previously approved these changes
Nov 19, 2020
Progi1984
added
the
Waiting for QA
Status: action required, waiting for test feedback
label
Nov 19, 2020
NeOMakinG
added
WIP
Status: Work In Progress
and removed
Waiting for QA
Status: action required, waiting for test feedback
labels
Nov 19, 2020
atomiix
approved these changes
Jan 5, 2021
PierreRambaud
approved these changes
Jan 5, 2021
PierreRambaud
added
the
Waiting for QA
Status: action required, waiting for test feedback
label
Jan 5, 2021
Progi1984
approved these changes
Jan 5, 2021
Hi @NeOMakinG, I checked some migrated page wth tooltip => ok (Administration page) Thanks! |
khouloudbelguith
added
QA ✔️
Status: check done, code approved
and removed
Waiting for QA
Status: action required, waiting for test feedback
labels
Jan 6, 2021
Thanks @NeOMakinG & @khouloudbelguith |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is