Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly generate cart error messages #21830

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Correctly generate cart error messages #21830

merged 1 commit into from
Nov 12, 2020

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Nov 10, 2020 •
edited by PierreRambaud
Loading

Questions Answers
Branch? 1.7.7.x
Description? The getErrorMessages returns the same array for every type of exception, so when we need to access a specific getter we must check the exception type and have a fallback
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #21794
How to test? See issue

This change is Reviewable

@jolelievre jolelievre requested a review from a team as a code owner November 10, 2020 09:22
@prestonBot prestonBot added 1.7.7.x Branch Bug Type: Bug labels Nov 10, 2020
@jolelievre jolelievre linked an issue Nov 10, 2020 that may be closed by this pull request
BO - Order page - An exception is displayed in the console when adding a product out of stock #21794
Closed
@jolelievre jolelievre added this to the 1.7.7.0 milestone Nov 10, 2020
@jolelievre jolelievre added the Waiting for dev Status: action required, waiting for tech feedback label Nov 10, 2020
Progi1984
Progi1984 reviewed Nov 10, 2020
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change :)

@Progi1984 Progi1984 removed the Waiting for dev Status: action required, waiting for tech feedback label Nov 10, 2020
@jolelievre jolelievre added the Waiting for dev Status: action required, waiting for tech feedback label Nov 10, 2020
@matks matks added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for dev Status: action required, waiting for tech feedback labels Nov 10, 2020
@khouloudbelguith khouloudbelguith self-assigned this Nov 12, 2020
@khouloudbelguith
Copy link
Contributor

Hi @jolelievre,

It is ok ✔️
https://drive.google.com/file/d/1jTs4fHTQq4xXE74zqrnR24KhocZ2eaZw/view?usp=sharing

Thanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 12, 2020
@Progi1984 Progi1984 merged commit bd4189f into PrestaShop:1.7.7.x Nov 12, 2020
@Progi1984
Copy link
Member

Thanks @jolelievre & @khouloudbelguith

@Progi1984 Progi1984 mentioned this pull request Nov 12, 2020
Closed
@jolelievre jolelievre deleted the minimal-quantity-exception branch February 2, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

@sowbiba sowbiba sowbiba approved these changes

Assignees

@khouloudbelguith khouloudbelguith

Labels
1.7.7.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

BO - Order page - An exception is displayed in the console when adding a product out of stock
6 participants
@jolelievre @khouloudbelguith @Progi1984 @matks @sowbiba @prestonBot