Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transformation traits from behats and implement contexts instead #21955

Merged
merged 5 commits into from
Nov 18, 2020

Conversation

zuk3975
Copy link
Contributor

@zuk3975 zuk3975 commented Nov 17, 2020

Questions Answers
Branch? develop
Description? Using traits as transformations in behat contexts isn't right because once you use the trait in one context it will be shared across whole Feature. That means all the other contexts will be unstable, as you are not aware if the trait is used in one or another context. So this PR provides simple yet a bit cleaner solution - instead of traits, implement Contexts with related transformations, so once we need a transformer, we add that transformer context to the feature in behat.yml and then its easier to spot when feature is dependant on transformer or not. (open to improvements, but this one was first and only idea how to reuse transformers for now)
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? travis ✔️

This change is Reviewable

@zuk3975 zuk3975 requested a review from a team as a code owner November 17, 2020 13:13
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Nov 17, 2020
jolelievre
jolelievre previously approved these changes Nov 17, 2020
@zuk3975 zuk3975 changed the title [WIP] Remove transformation traits from behats and implement contexts instead Remove transformation traits from behats and implement contexts instead Nov 17, 2020
@zuk3975
Copy link
Contributor Author

zuk3975 commented Nov 17, 2020

rr travis 😭

@matks matks added this to the 1.7.8.0 milestone Nov 17, 2020
@matks matks added the migration symfony migration project label Nov 17, 2020
@jolelievre jolelievre merged commit dea4c28 into PrestaShop:develop Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch migration symfony migration project Refactoring Type: Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants