Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take shop id into account when getting a language list for an order #22020

Merged
merged 6 commits into from
Dec 16, 2020
Merged

Take shop id into account when getting a language list for an order #22020

merged 6 commits into from
Dec 16, 2020

Conversation

matthieu-rolland
Copy link
Contributor

@matthieu-rolland matthieu-rolland commented Nov 19, 2020 •
edited
Loading

Questions Answers
Branch? 1.7.7.x
Description? Current shop was not taken into account when getting the list of available languages
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #21817
How to test? See issue #21817

This change is Reviewable

BC BREAK:

LanguageByIdChoiceProvider 's interface was changed from FormChoiceProviderInterface to ConfigurableFormChoiceProviderInterface, as a consequence its getOptions method now takes an array of options as a parameter (default: empty array).

@matthieu-rolland matthieu-rolland requested a review from a team as a code owner November 19, 2020 16:55
@prestonBot prestonBot added 1.7.7.x Branch Improvement Type: Improvement labels Nov 19, 2020
@matthieu-rolland matthieu-rolland changed the title take shop id into account when searching for languages take shop id into account when getting a language list for an order Nov 19, 2020
@PierreRambaud PierreRambaud changed the title take shop id into account when getting a language list for an order Take shop id into account when getting a language list for an order Nov 19, 2020
@matthieu-rolland matthieu-rolland added this to the 1.7.7.1 milestone Nov 20, 2020
@Progi1984
Copy link
Member

@matthieu-rolland Unit tests are broken : https://travis-ci.com/github/PrestaShop/PrestaShop/obs/444245142#L651

@Progi1984 Progi1984 added the Waiting for author Status: action required, waiting for author feedback label Nov 23, 2020
Progi1984
Progi1984 reviewed Nov 25, 2020
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback

@Progi1984 Progi1984 linked an issue Nov 26, 2020 that may be closed by this pull request
Multistore - BO - Order page - All languages are available in the dropdown for Language in the Add new Order page #21817
Closed
atomiix
atomiix previously approved these changes Nov 26, 2020
View reviewed changes
Progi1984
Progi1984 previously approved these changes Nov 26, 2020
View reviewed changes
@Progi1984 Progi1984 removed the Waiting for author Status: action required, waiting for author feedback label Nov 26, 2020
PierreRambaud
PierreRambaud previously approved these changes Dec 7, 2020
View reviewed changes
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Dec 7, 2020
@khouloudbelguith khouloudbelguith self-assigned this Dec 8, 2020
@khouloudbelguith
Copy link
Contributor

Hi @matthieu-rolland,

I have an exception following these steps:

  1. Go to BO > International > localization > See error

image

Thanks!

@khouloudbelguith khouloudbelguith added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 8, 2020
@Progi1984 Progi1984 removed the Waiting for author Status: action required, waiting for author feedback label Dec 16, 2020
jolelievre
jolelievre approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthieu-rolland All good, however since we change the interface and the prototype of the function it should be documented as a BC break (even if it's a small and acceptable one)
You just need to update the PR description for documentation

@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Dec 16, 2020
@khouloudbelguith
Copy link
Contributor

Hi @matthieu-rolland,

It is ok ✔️
https://drive.google.com/file/d/1EuPWz3uMmSCm2yvWIlGhaEcT9gd1zH_J/view?usp=sharing

Thanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 16, 2020
@Progi1984 Progi1984 merged commit 4d15e06 into PrestaShop:1.7.7.x Dec 16, 2020
@Progi1984
Copy link
Member

Thanks @matthieu-rolland & @khouloudbelguith

@Progi1984 Progi1984 mentioned this pull request Dec 16, 2020
Closed
@khouloudbelguith khouloudbelguith mentioned this pull request Dec 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@jolelievre jolelievre jolelievre approved these changes

@PierreRambaud PierreRambaud PierreRambaud left review comments

@atomiix atomiix atomiix left review comments

Assignees

@khouloudbelguith khouloudbelguith

Labels
1.7.7.x Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.7.1
7 participants
@matthieu-rolland @Progi1984 @khouloudbelguith @PierreRambaud @atomiix @jolelievre @prestonBot