Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed override of ps_searchbar #22032

Merged

Conversation

Progi1984
Copy link
Member

@Progi1984 Progi1984 commented Nov 20, 2020

Questions Answers
Branch? develop
Description? Removed override of ps_searchbar
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? To test with PrestaShop/ps_searchbar#24

This change is Reviewable

@Progi1984 Progi1984 requested a review from a team as a code owner November 20, 2020 14:17
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Bug Type: Bug labels Nov 20, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Nov 20, 2020
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Nov 20, 2020
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 11, 2020
@PierreRambaud PierreRambaud merged commit 9be0b6d into PrestaShop:develop Dec 11, 2020
@PierreRambaud
Copy link
Contributor

Danke bro

@Progi1984 Progi1984 deleted the fixProductCommentsRelease202 branch May 6, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants