Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused function on the linkchecker #22194

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Delete unused function on the linkchecker #22194

merged 1 commit into from
Dec 3, 2020

Conversation

boubkerbribri
Copy link
Contributor

@boubkerbribri boubkerbribri commented Dec 2, 2020 •
edited by PierreRambaud
Loading

Questions Answers
Branch? develop
Description? Delete unused function on the linkchecker
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? no tests needed

This change is Reviewable

@boubkerbribri boubkerbribri added the TE Category: Tests label Dec 2, 2020
@boubkerbribri boubkerbribri added this to the 1.7.8.0 milestone Dec 2, 2020
@boubkerbribri boubkerbribri requested a review from a team as a code owner December 2, 2020 15:37
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Dec 2, 2020
@Progi1984 Progi1984 added the QA ✔️ Status: check done, code approved label Dec 2, 2020
@SimonGrn SimonGrn merged commit 7632af1 into PrestaShop:develop Dec 3, 2020
@boubkerbribri boubkerbribri deleted the fix-linkchecker branch May 12, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

@nesrineabdmouleh nesrineabdmouleh Awaiting requested review from nesrineabdmouleh

@SimonGrn SimonGrn Awaiting requested review from SimonGrn

Assignees
No one assigned
Labels
develop Branch QA ✔️ Status: check done, code approved Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@boubkerbribri @Progi1984 @NeOMakinG @prestonBot @SimonGrn