Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed case where saving virtual product attachment is modifying product price if a specific price is set on the product #22376

Merged
merged 1 commit into from Dec 17, 2020
Merged

Fixed case where saving virtual product attachment is modifying product price if a specific price is set on the product #22376

merged 1 commit into from Dec 17, 2020

Conversation

gennaris
Copy link
Contributor

@gennaris gennaris commented Dec 11, 2020 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? Fixes #22069 - no need to instantiate "full" product here - otherwise price is getting recalculated on subsequential product->save() if there's a specific price on the product itself- this causes price lowering after any virtual product attachment save. looks like quite major issue to me as it scrambled many prices of customer shop.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #22069
How to test? See #22069

This change is Reviewable

@gennaris gennaris requested a review from a team as a code owner December 11, 2020 17:47
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Dec 11, 2020
@Progi1984 Progi1984 changed the title fix for #22069 - Saving virtual product attachment is modifying product price if a specific price is set on the product Fixed case where saving virtual product attachment is modifying product price if a specific price is set on the product Dec 14, 2020
@matthieu-rolland matthieu-rolland added the Waiting for QA Status: action required, waiting for test feedback label Dec 16, 2020
@SD1982 SD1982 self-assigned this Dec 17, 2020
@SD1982
Copy link
Contributor

SD1982 commented Dec 17, 2020

LGTM !!
https://drive.google.com/file/d/1rfPvgQ3ZEloKy8oIrf7kgH4aUvp0RfmJ/view?usp=sharing
Thanks @gennaris !!

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 17, 2020
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@PierreRambaud PierreRambaud merged commit 834139d into PrestaShop:develop Dec 17, 2020
@prestonBot
Copy link
Collaborator

Contribution merged, congratulations!

Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-)

@PierreRambaud
Copy link
Contributor

Thank you @gennaris

@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Dec 17, 2020
@gennaris gennaris deleted the fix-22069 branch December 19, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees

@SD1982 SD1982

Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Saving virtual product attachment is modifying product price if a specific price is set on the product
6 participants
@gennaris @SD1982 @prestonBot @PierreRambaud @Progi1984 @matthieu-rolland