Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FO password reminder test with maildev #22932

Merged
merged 17 commits into from
Feb 23, 2021
Merged

FO password reminder test with maildev #22932

merged 17 commits into from
Feb 23, 2021

Conversation

SD1982
Copy link
Contributor

@SD1982 SD1982 commented Jan 21, 2021 •
edited by PierreRambaud
Loading

Questions Answers
Branch? develop
Description? Add a new test "password reminder"
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? //.
How to test? Can be tested with this command `TEST_PATH="functional/FO/01_login/01_passwordReminder" URL_FO="your FO url" npm run specific-test
Possible impacts? Nothing only tests.

This change is Reviewable

@SD1982 SD1982 added TE Category: Tests develop Branch Refactoring Type: Refactoring WIP Status: Work In Progress labels Jan 21, 2021
@SD1982 SD1982 self-assigned this Jan 21, 2021
@SD1982 SD1982 requested a review from a team as a code owner January 21, 2021 15:29
boubkerbribri
boubkerbribri reviewed Jan 21, 2021
View reviewed changes
Copy link
Contributor

@boubkerbribri boubkerbribri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments about test

tests/UI/pages/FO/passwordReminder/index.js Outdated Show resolved Hide resolved
tests/UI/pages/FO/passwordReminder/index.js Outdated Show resolved Hide resolved
themes/classic/templates/customer/password-email.tpl Outdated Show resolved Hide resolved
themes/classic/templates/customer/password-email.tpl Outdated Show resolved Hide resolved
tests/UI/pages/FO/passwordReminder/index.js Outdated Show resolved Hide resolved
tests/UI/pages/BO/advancedParameters/email/index.js Outdated Show resolved Hide resolved
tests/UI/campaigns/commonTests/loginFO.js Show resolved Hide resolved
tests/UI/campaigns/commonTests/loginFO.js Outdated Show resolved Hide resolved
tests/UI/campaigns/commonTests/loginFO.js Show resolved Hide resolved
@boubkerbribri boubkerbribri changed the title Add password reminder test [WIP]Add password reminder test Jan 21, 2021
@SD1982 SD1982 changed the title [WIP]Add password reminder test [WIP]FO password reminder test with maildev Jan 22, 2021
@SD1982 SD1982 removed the WIP Status: Work In Progress label Feb 11, 2021
@SD1982 SD1982 changed the title [WIP]FO password reminder test with maildev FO password reminder test with maildev Feb 11, 2021
SimonGrn
SimonGrn reviewed Feb 12, 2021
View reviewed changes
tests/UI/README.md Show resolved Hide resolved
tests/UI/campaigns/tools/stepIdentifiersChecker.js Outdated Show resolved Hide resolved
SD1982 and others added 12 commits February 18, 2021 10:57
@SD1982
Add new test for password reminder
9d23e59
@SD1982
add mailHelper file and more
39c2f69
@SD1982 @boubkerbribri
Update tests/UI/pages/FO/passwordReminder/index.js
5a46ad6 
Co-authored-by: boubkerbribri <48441421+boubkerbribri@users.noreply.github.com>
@SD1982 @boubkerbribri
Update tests/UI/pages/FO/passwordReminder/index.js
48888cd 
Co-authored-by: boubkerbribri <48441421+boubkerbribri@users.noreply.github.com>
@SD1982 @boubkerbribri
Update themes/classic/templates/customer/password-email.tpl
19044c9 
Co-authored-by: boubkerbribri <48441421+boubkerbribri@users.noreply.github.com>
@SD1982 @boubkerbribri
Update themes/classic/templates/customer/password-email.tpl
496dc6c 
Co-authored-by: boubkerbribri <48441421+boubkerbribri@users.noreply.github.com>
@SD1982
remove useless screenshot
cf3bc81
@SD1982
fix lint errors
34fd63e
@SD1982
update readme file
8247f88
@SD1982
update readme & globals
6da53b5
@SD1982
force docker container ip address
abdaf34
@SD1982
resolve duplicate stepIdentifiers
9f410d6
Progi1984
Progi1984 reviewed Feb 22, 2021
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small feedbacks

SD1982 and others added 2 commits February 22, 2021 18:49
@SD1982 @Progi1984
Update tests/UI/campaigns/functional/FO/01_login/01_passwordReminder.js
1f48e07 
Co-authored-by: Progi1984 <progi1984@gmail.com>
@SD1982 @Progi1984
Update tests/UI/campaigns/tools/stepIdentifiersChecker.js
2037a79 
Co-authored-by: Progi1984 <progi1984@gmail.com>
@Progi1984 Progi1984 merged commit 6cc8f20 into PrestaShop:develop Feb 23, 2021
@Progi1984
Copy link
Member

Tahnks @SD1982

@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@boubkerbribri boubkerbribri boubkerbribri approved these changes

@nesrineabdmouleh nesrineabdmouleh Awaiting requested review from nesrineabdmouleh

@SimonGrn SimonGrn Awaiting requested review from SimonGrn

Assignees

@SD1982 SD1982

Labels
develop Branch E2E Tests Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SD1982 @Progi1984 @boubkerbribri @SimonGrn