Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sidebar visibility when hidden by default on default theme #23069

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Fix sidebar visibility when hidden by default on default theme #23069

merged 1 commit into from
Feb 8, 2021

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Feb 1, 2021 •
edited by PierreRambaud
Loading

Questions Answers
Branch? develop
Description? Sidebar items were hidden if you refresh the page on default theme (dashboard for example) with sidebar hidden
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #23026.
How to test? Go on dashboard, hide the sidebar, refresh the page, show the sidebar : items should be visible
Possible impacts? BO Default theme

This change is Reviewable

@NeOMakinG NeOMakinG added this to the 1.7.8.0 milestone Feb 1, 2021
@NeOMakinG NeOMakinG requested a review from a team as a code owner February 1, 2021 11:23
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Feb 1, 2021
@matthieu-rolland matthieu-rolland added the Waiting for QA Status: action required, waiting for test feedback label Feb 8, 2021
@SD1982 SD1982 self-assigned this Feb 8, 2021
@SD1982
Copy link
Contributor

SD1982 commented Feb 8, 2021

LGTM !!
Tested:

  • initial case
  • all links
  • dropdown
  • mobile device
  • firefox

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 8, 2021
@Progi1984 Progi1984 merged commit acf32d1 into PrestaShop:develop Feb 8, 2021
@Progi1984
Copy link
Contributor

Thanks @NeOMakinG & @SD1982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees

@SD1982 SD1982

Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

After collapsing navbar, if I go to legacy BO page and expand navbar, navbar entries have no titles
6 participants
@NeOMakinG @SD1982 @Progi1984 @PierreRambaud @matthieu-rolland @prestonBot