Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure key exists before using it #23473

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Make sure key exists before using it #23473

merged 1 commit into from
Mar 2, 2021

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Mar 2, 2021 •
edited
Loading

Questions Answers
Branch? develop
Description? Since PHP 7.4 you can't use boolean as array.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
How to test? IMHO No need QA.
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from a team as a code owner March 2, 2021 10:12
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Mar 2, 2021
@PrestaShop PrestaShop deleted a comment from prestonBot Mar 2, 2021
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Mar 2, 2021
@atomiix atomiix merged commit 93da189 into PrestaShop:develop Mar 2, 2021
@atomiix
Copy link
Contributor

atomiix commented Mar 2, 2021

Thanks @PierreRambaud!

@PierreRambaud PierreRambaud deleted the fix/getTaxesName-method branch March 2, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@atomiix atomiix atomiix approved these changes

Assignees
No one assigned
Labels
Bug fix Type: Bug fix develop Branch
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@PierreRambaud @atomiix @Progi1984 @prestonBot