Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logout and hover colors on profile pan responsive #23568

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Fix logout and hover colors on profile pan responsive #23568

merged 2 commits into from
Mar 11, 2021

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Mar 8, 2021 •
edited by PierreRambaud
Loading

Questions Answers
Branch? develop
Description? Profile pan needed some adjustements on colors on mobile, normal item need to have a background using primary colors and signout needs a background with red color
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #23102.
How to test? Go on legacy page AND migrated page and check Profile pan colors on mobile (see issues contains screens)
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from a team as a code owner March 8, 2021 17:13
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Mar 8, 2021
@NeOMakinG NeOMakinG added this to the 1.7.8.0 milestone Mar 8, 2021
@prestascott
Copy link

Almost perfect, can you replace the icon used for "Your profile" button by this one:
image

Great work, thank you!!

@prestascott prestascott added the UX ✔️ Status: check done, design approved label Mar 9, 2021
Progi1984
Progi1984 previously approved these changes Mar 9, 2021
View reviewed changes
@NeOMakinG NeOMakinG requested review from Progi1984 and a team March 9, 2021 16:55
@NeOMakinG NeOMakinG closed this Mar 10, 2021
@NeOMakinG NeOMakinG reopened this Mar 10, 2021
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Mar 10, 2021
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 10, 2021
@PierreRambaud PierreRambaud merged commit 6f341d7 into PrestaShop:develop Mar 11, 2021
@PierreRambaud
Copy link
Contributor

Thank you @NeOMakinG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees

@prestascott prestascott

Labels
Bug fix Type: Bug fix develop Branch QA ✔️ Status: check done, code approved UX ✔️ Status: check done, design approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

[BO - RESPONSIVE] Profile block needs some improvements to be more UX on mobile
7 participants
@NeOMakinG @prestascott @PierreRambaud @Progi1984 @matthieu-rolland @sarahdib @prestonBot