Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update js documentation for Credit slips - Delivery slips - Invoices - Shopping carts pages #24240

Merged
merged 6 commits into from
Apr 30, 2021
Merged

Update js documentation for Credit slips - Delivery slips - Invoices - Shopping carts pages #24240

merged 6 commits into from
Apr 30, 2021

Conversation

nesrineabdmouleh
Copy link
Contributor

@nesrineabdmouleh nesrineabdmouleh commented Apr 27, 2021 •
edited by PierreRambaud
Loading

Questions Answers
Branch? 1.7.8.x
Description? Update js documentation for (Credit slips - Delivery slips - Invoices - Shopping carts) pages
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? no need
Possible impacts? no

This change is Reviewable

@nesrineabdmouleh nesrineabdmouleh requested a review from a team as a code owner April 27, 2021 14:33
@prestonBot prestonBot added 1.7.8.x Branch Refactoring Type: Refactoring labels Apr 27, 2021
@nesrineabdmouleh nesrineabdmouleh added E2E Tests TE Category: Tests labels Apr 27, 2021
@nesrineabdmouleh nesrineabdmouleh added the QA ✔️ Status: check done, code approved label Apr 30, 2021
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@boubkerbribri boubkerbribri added this to the 1.7.8.0 milestone Apr 30, 2021
@Progi1984 Progi1984 merged commit fbc64da into PrestaShop:1.7.8.x Apr 30, 2021
@Progi1984
Copy link
Member

Thanks @nesrineabdmouleh

@nesrineabdmouleh nesrineabdmouleh deleted the updateJsDocumentation branch April 6, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

@boubkerbribri boubkerbribri Awaiting requested review from boubkerbribri

Assignees
No one assigned
Labels
1.7.8.x Branch E2E Tests QA ✔️ Status: check done, code approved Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nesrineabdmouleh @prestonBot @Progi1984 @PierreRambaud @NeOMakinG @boubkerbribri