Search Conf Incorrect successful alert message

[ghost]

Questions	Answers
Branch?	develop
Description?	n the BO > Search page, when we try to update an alias, the successful message is displayed. Creation successful instead of Update successful
Type?	bug fix
Category?	BO
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #21867
How to test?	Check the wording
Possible impacts?	Please indicate what parts of the software we need to check to make sure everything is alright.

---

This change is 

[PululuK]

@okom3pom LGTM !
Just improve wording.

[ghost]

Thank you @PululuK && @Julievrz

[Robin-Fischer-PS]

Hi there !

I think the problem is a bit more complex for this page, because the "Edit alias" can give 3 different results depending on what's modified in the form, and I'm not sure the correct message should always be "Update successful".

Ping @PrestaShop/product-team , need some help for this one !

• Case 1 :

I edit only the "Result" field : In this case, it's indeed only an update of the alias, no new alias is created. For this case, the message is OK.
In the DB, the alias is updated too.

Edit page :

Result :

• Case 2 :

I edit both "Alias" and "Result" field : In this case, a new alias is created in addition to the original one. IMHO, the message is not OK : It should be "Successful creation". Or the behavior should be modified and the original alias should be replaced by the new one.
In DB, a new alias is indeed created and the original one is not modified.

Edit page :

Result :

• Case 3 :

I edit only the "Alias" field : In this case, a new alias is created in addition to the original one, but if I edit the same alias again, both aliases are displayed in the "Alias" field. In this case, I'm not sure what should be the message displayed...
In DB, a new alias is created and the original one is not modified.

Edit page :

Result :

Both aliases in one edit page :

I made a screenrecord of these 3 cases :

https://drive.google.com/file/d/1GYGQw6sCNiFH7ZThWw6xRklJxi7yc1Eu/view?usp=sharing

Thanks :)

[MatShir]

There is a problem in the behavior as @Robin-Fischer-PS pointed out. In any case, this is an update workflow, so the message is correct even if the actions lead to the creation of a new alias. The behavior is not new, I could reproduce the problem in 1.7.6. So we are not going to adapt the message to a faulty behavior, but we should correct the behavior to match the action and follow the message.
The PR is good, but fixing the behavior should be the subject of another PR.

[Robin-Fischer-PS]

Thanks @MatShir !

Then this PR is OK :
Display of the confirmation message on edit : ✔️
Display of the confirmation message on creation : ✔️

It's QA ✔️ ! Thanks @okom3pom :)

[prestonBot]

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

[PululuK]

Thanks @okom3pom @Robin-Fischer-PS