Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix smarty product lazy load exception #24379

Merged
merged 1 commit into from May 10, 2021
Merged

Fix smarty product lazy load exception #24379

merged 1 commit into from May 10, 2021

Conversation

atomiix
Copy link
Contributor

@atomiix atomiix commented May 6, 2021 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.8.x
Description? When smarty tries to lazy load a product, it will throw an error if the type of smarty variable changes (from string to array for instance). This PR fixes it by not reassigning the attributes variable if already defined.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #21950
How to test? Please see #21950
Possible impacts?

This change is Reviewable

@atomiix atomiix requested a review from a team as a code owner May 6, 2021 15:42
@prestonBot prestonBot added 1.7.8.x Branch Bug fix Type: Bug fix labels May 6, 2021
@atomiix atomiix added this to the 1.7.8.0 milestone May 6, 2021
@atomiix atomiix linked an issue May 6, 2021 that may be closed by this pull request
FO - An exception is displayed in the guest-tracking controller (when logged out) and in order details when logged in #21950
Closed
@Progi1984
Copy link
Contributor

@atomiix Please rebase your PR for fixing CI.

@atomiix atomiix closed this May 7, 2021
@atomiix atomiix reopened this May 7, 2021
@kpodemski kpodemski added the Waiting for QA Status: action required, waiting for test feedback label May 7, 2021
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this May 10, 2021
@Robin-Fischer-PS Robin-Fischer-PS added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels May 10, 2021
@Robin-Fischer-PS
Copy link
Contributor

Hi @atomiix ,

I checked guest and logged-in view order details on FO, and view order on BO, with all types of product and different languages : OK

So it's QA ✔️ !

Thanks :)

@atomiix atomiix merged commit cc6db00 into PrestaShop:1.7.8.x May 10, 2021
@atomiix atomiix deleted the fix/21950 branch May 10, 2021 12:56
@atomiix
Copy link
Contributor Author

atomiix commented May 10, 2021

Thanks @Robin-Fischer-PS

@Progi1984 Progi1984 mentioned this pull request May 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@kpodemski kpodemski kpodemski approved these changes

@matks matks matks approved these changes

Assignees

@Robin-Fischer-PS Robin-Fischer-PS

Labels
1.7.8.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
7 participants
@atomiix @Progi1984 @Robin-Fischer-PS @matthieu-rolland @kpodemski @matks @prestonBot