Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm vulnerabilities and update webpack everywhere except classic #24572

Merged
merged 10 commits into from
May 26, 2021
Merged

Fix npm vulnerabilities and update webpack everywhere except classic #24572

merged 10 commits into from
May 26, 2021

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented May 19, 2021 •
edited by PierreRambaud
Loading

Questions Answers
Branch? 1.7.8.x
Description? Our npm dependencies had a lot of vulnerabilities, it's mainly fixed by running npm audit fix and update webpack and all other dependencies (Notice that classic theme has not really been touched, another PR is opened for it)
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Not sure it has to be tested, but styles and JS in the BO should be as usually
Possible impacts? Assets build

This change is Reviewable

@NeOMakinG NeOMakinG added this to the 1.7.8.0 milestone May 19, 2021
@NeOMakinG NeOMakinG requested a review from a team as a code owner May 19, 2021 15:07
@prestonBot prestonBot added 1.7.8.x Branch Bug fix Type: Bug fix labels May 19, 2021
@NeOMakinG NeOMakinG changed the title Fix npm audit Fix npm vulnerabilities and update webpack everywhere except classic May 19, 2021
@PrestaShop PrestaShop deleted a comment from prestonBot May 19, 2021
PierreRambaud
PierreRambaud previously approved these changes May 19, 2021
View reviewed changes
Progi1984
Progi1984 previously approved these changes May 19, 2021
View reviewed changes
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label May 19, 2021
@Progi1984
Copy link
Member

@PrestaShop/qa-functional Do we send it to QA ? (Major changes versions for packages)

@NeOMakinG
Copy link
Author

@PrestaShop/qa-functional Do we send it to QA ? (Major changes versions for packages)

It's mainly dev dependencies, so the QA may test the asset build/watch and could do an otherall check on some pages, but no need to inspect everything I think

@Robin-Fischer-PS
Copy link
Contributor

I think it would be best to have this one in QA indeed, we will test it before the Beta (as @NeOMakinG said, we will not test all the BO, just some pages.

@NeOMakinG NeOMakinG dismissed stale reviews from Progi1984 and PierreRambaud via 6ddddcf May 19, 2021 16:32
@NeOMakinG NeOMakinG added WIP Status: Work In Progress and removed Waiting for QA Status: action required, waiting for test feedback labels May 19, 2021
@NeOMakinG NeOMakinG removed the WIP Status: Work In Progress label May 19, 2021
Progi1984
Progi1984 reviewed May 20, 2021
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment

Progi1984
Progi1984 previously approved these changes May 20, 2021
View reviewed changes
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label May 20, 2021
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this May 26, 2021
@Robin-Fischer-PS
Copy link
Contributor

Hi @NeOMakinG !

@SD1982 did a BO full automated test campaign, and I didManual navigation on some pages on BO, both have shown no defect in behavior or display.

So it's QA ✔️ , thanks !

@Robin-Fischer-PS Robin-Fischer-PS added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels May 26, 2021
@matks
Copy link
Contributor

matks commented May 26, 2021

Thank you @NeOMakinG

@matks matks merged commit 2a9fac0 into PrestaShop:1.7.8.x May 26, 2021
@jolelievre jolelievre mentioned this pull request May 27, 2021
Merged
@hibatallahAouadni hibatallahAouadni mentioned this pull request May 27, 2021
Closed
@matks matks added the Key feature Notable feature to be highlighted label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees

@Robin-Fischer-PS Robin-Fischer-PS

Labels
1.7.8.x Branch Bug fix Type: Bug fix Key feature Notable feature to be highlighted QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@NeOMakinG @Progi1984 @Robin-Fischer-PS @matks @PierreRambaud @prestonBot