Fix bug PSCSX-4596. duplicatde filter selection #2458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you choose "Default order by PRODUCT PRICE, PRODUCT NAME, PRODUCT QUANTITY or PRODUCT REFERENCE" in back office settings, the selected attribute of #selectProductSort in front office duplicates that leads to errors in old browser. here is the html code of such an error in product_sort.tpl in any category <select id="selectProductSort" class="selectProductSort form-control"> <option value="price:asc" SELECTED="SELECTED">--</option> <option value="price:asc" SELECTED="SELECTED">Price: Lowest first</option> <option value="price:desc">Price: Highest first</option> <option value="name:asc">Product Name: A to Z</option> <option value="name:desc">Product Name: Z to A</option> <option value="quantity:desc">In stock</option> <option value="reference:asc">Reference: Lowest first</option> <option value="reference:desc">Reference: Highest first</option> </select> that code will never pass w3c validation as well. If you choose other options in back office the problem dissappeare
fix bug #PSCSX-4596
Revert "fix bug #PSCSX-4596"
gRoussac
added a commit
that referenced
this pull request
Feb 9, 2015
|
nice |
|
Thank you. Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you choose "Default order by PRODUCT PRICE, PRODUCT NAME, PRODUCT QUANTITY or PRODUCT REFERENCE" in back office settings, the selected attribute of #selectProductSort in front office duplicates that leads to errors in old browser.
here is the html code of such an error in product_sort.tpl in any category
[select id="selectProductSort" class="selectProductSort form-control"]
[option value="price:asc" SELECTED="SELECTED"]--[/option]
[option value="price:asc" SELECTED="SELECTED"]Price: Lowest first[/option]
[option value="price:desc"]Price: Highest first[/option]
[option value="name:asc"]Product Name: A to Z[/option]
[option value="name:desc"]Product Name: Z to A[/option]
[option value="quantity:desc"]In stock[/option]
[option value="reference:asc"]Reference: Lowest first[/option]
[option value="reference:desc"]Reference: Highest first[/option]
[/select]
that code will never pass w3c validation as well. If you choose other options in back office the problem dissappeared.