Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug PSCSX-4596. duplicatde filter selection #2458

Closed
wants to merge 4 commits into from
Closed

Fix bug PSCSX-4596. duplicatde filter selection #2458

wants to merge 4 commits into from

Commits on Feb 6, 2015

  1. fix bug #PSCSX-4596 

    If you choose "Default order by PRODUCT PRICE, PRODUCT NAME, PRODUCT QUANTITY or PRODUCT REFERENCE" in back office settings, the selected attribute of #selectProductSort in front office duplicates that leads to errors in old browser.
here is the html code of such an error in product_sort.tpl in any category
<select id="selectProductSort" class="selectProductSort form-control">
<option value="price:asc" SELECTED="SELECTED">--</option>
<option value="price:asc" SELECTED="SELECTED">Price: Lowest first</option>
<option value="price:desc">Price: Highest first</option>
<option value="name:asc">Product Name: A to Z</option>
<option value="name:desc">Product Name: Z to A</option>
<option value="quantity:desc">In stock</option>
<option value="reference:asc">Reference: Lowest first</option>
<option value="reference:desc">Reference: Highest first</option>
</select>
that code will never pass w3c validation as well. If you choose other options in back office the problem dissappeare
    @ikorogodsky
    ikorogodsky committed Feb 6, 2015
    Configuration menu
    Copy the full SHA
    b70ed15 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from ikorogodsky/ikorogodsky-patch-1 

    fix bug #PSCSX-4596
    @ikorogodsky
    ikorogodsky committed Feb 6, 2015
    Configuration menu
    Copy the full SHA
    fb03f25 View commit details
    Browse the repository at this point in the history

  3. Revert "fix bug #PSCSX-4596"

    @ikorogodsky
    ikorogodsky committed Feb 6, 2015
    Configuration menu
    Copy the full SHA
    ba62b00 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2 from ikorogodsky/revert-1-ikorogodsky-patch-1 

    Revert "fix bug #PSCSX-4596"
    @ikorogodsky
    ikorogodsky committed Feb 6, 2015
    Configuration menu
    Copy the full SHA
    61bc2e8 View commit details
    Browse the repository at this point in the history