Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forgotten contributor in CONTRIBUTORS.md #24905

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

micka-fdz
Copy link
Contributor

@micka-fdz micka-fdz commented Jun 10, 2021

Questions Answers
Branch? 1.7.8.x
Description? Add forgotten contributor in CONTRIBUTORS.md
Type? improvement
Category? PM
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? -
Possible impacts? -

This change is Reviewable

@micka-fdz micka-fdz requested a review from a team as a code owner June 10, 2021 09:57
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • The description shouldn't be empty.
  • The type should be one of these: new feature, improvement, bug fix or refacto (Read explanation).
  • The category should be one of these: BO, CO, FO, IN, LO, ME, PM, TE or WS (Read explanation)
  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@Progi1984 Progi1984 changed the title Ajout dans CONTRIBUTORS.md Add forgotten contributor in CONTRIBUTORS.md Jun 10, 2021
@prestonBot prestonBot added the 1.7.8.x Branch label Jun 10, 2021
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Jun 10, 2021
@matthieu-rolland matthieu-rolland merged commit c4abd8c into PrestaShop:1.7.8.x Jun 11, 2021
@prestonBot
Copy link
Collaborator

Contribution merged, congratulations!

Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-)

@matthieu-rolland
Copy link
Contributor

thank you @micka-fdz !

@prestonBot prestonBot added the Improvement Type: Improvement label Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.8.x Branch Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants