Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node sass #24919

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Update node sass #24919

merged 4 commits into from
Jun 15, 2021

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Jun 11, 2021 •
edited by PierreRambaud
Loading

Questions Answers
Branch? develop
Description? We need to update node-sass and sass-loader inside our BO themes to avoid security issues
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Nothing should be impacted, but maybe css builds
Possible impacts? CSS builds

This change is Reviewable

@NeOMakinG NeOMakinG added this to the 1.7.9.0 milestone Jun 11, 2021
@NeOMakinG NeOMakinG requested a review from a team as a code owner June 11, 2021 12:52
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Jun 11, 2021
@PrestaShop PrestaShop deleted a comment from prestonBot Jun 11, 2021
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Jun 14, 2021
boubkerbribri
boubkerbribri approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@boubkerbribri boubkerbribri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with UI tests (functional campaign).
Besides the bug on category page, not linked to this PR, it's LGTM for QA.

@boubkerbribri boubkerbribri added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 15, 2021
@atomiix atomiix merged commit 178f65c into PrestaShop:develop Jun 15, 2021
@atomiix
Copy link
Contributor

atomiix commented Jun 15, 2021

Thanks @NeOMakinG & @boubkerbribri!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@boubkerbribri boubkerbribri boubkerbribri approved these changes

Assignees
No one assigned
Labels
Bug fix Type: Bug fix develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@NeOMakinG @atomiix @PierreRambaud @Progi1984 @boubkerbribri @prestonBot