-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In case multiple payment options are available #25069
Conversation
In case multiple payment options are available
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! (Note: this is an automated message, but answering it will reach a real human) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @moncef-essid for your contribution 👍
While your modification makes sense we ask our contributors to create an issue and then properly link it in the PR description so that our PM team can properly track the project, and our QA team can understand how to validate your work:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
develop
will become 8.0.0 and BC breaks are acceptable.
I approve the PR. I also updated the PR body.
@moncef-essid Thanks for your contribution. Could you create an issue, please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but I hope we don't break anything else by just changing this ID, overwise we would need to fix it in this PR
I close and reopen the PR. |
@PierreRambaud ready to merge I guess? |
Contribution merged, congratulations! Would you mind answering our quick 1-minute survey? We would love to hear about your experience so far, it will help us improve our process for the community involved, like you. ;-) |
Thank you @moncef-essid |
In case multiple payment options are available
payment-form
ID. Modify the ID name to make it different.payment-form
IDsBC Break
Change of HTML ID
payment-form
topayment-{$option.id}-form
This change is