Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix languages test install #25320

Merged
merged 4 commits into from
Jul 21, 2021
Merged

Fix languages test install #25320

merged 4 commits into from
Jul 21, 2021

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Jul 12, 2021 •
edited by PierreRambaud
Loading

Questions Answers
Branch? 1.7.8.x
Description? The languages installed for tests fail randomly, sometimes only English is present sometimes french and English This PR aims to uniform this behaviour to have a consistent test environment
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? ~
How to test? ~
Possible impacts? ~

This change is Reviewable

@jolelievre jolelievre requested a review from a team as a code owner July 12, 2021 12:24
@prestonBot prestonBot added 1.7.8.x Branch Bug fix Type: Bug fix labels Jul 12, 2021
@jolelievre jolelievre changed the base branch from develop to 1.7.8.x July 12, 2021 12:24
@matks
Copy link
Contributor

matks commented Jul 15, 2021

@jolelievre can we close this PR?

@jolelievre
Copy link
Contributor Author

I wonder, this one still brings a little bit of value We don't need to install the shop initially since Databasecreator can now handle it all

@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Jul 21, 2021
@atomiix atomiix merged commit 2372ec9 into PrestaShop:1.7.8.x Jul 21, 2021
@atomiix
Copy link
Contributor

atomiix commented Jul 21, 2021

Thanks @jolelievre!

@jolelievre jolelievre deleted the fix-languages-test-install branch June 9, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud left review comments

@Progi1984 Progi1984 Progi1984 approved these changes

@atomiix atomiix atomiix approved these changes

Assignees
No one assigned
Labels
1.7.8.x Branch Bug fix Type: Bug fix
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jolelievre @matks @atomiix @PierreRambaud @Progi1984 @prestonBot