Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product flags: Fixed spacing with multiples flags on frontoffice #25387

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Product flags: Fixed spacing with multiples flags on frontoffice #25387

merged 1 commit into from
Sep 3, 2021

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Jul 20, 2021 •
edited by PierreRambaud
Loading

Questions Answers
Branch? 1.7.8.x
Description? Product flags: Fixed spacing with multiples flags on frontoffice
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #25272
How to test? Cf #25272

This change is Reviewable

@Progi1984 Progi1984 requested a review from a team as a code owner July 20, 2021 14:26
@prestonBot prestonBot added 1.7.8.x Branch Bug fix Type: Bug fix labels Jul 20, 2021
@Progi1984 Progi1984 linked an issue Jul 20, 2021 that may be closed by this pull request
FO - the product-flags must be on the same row but with spaces #25272
Closed
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Jul 20, 2021
@matthieu-rolland matthieu-rolland added the Waiting for QA Status: action required, waiting for test feedback label Jul 22, 2021
@florine2623 florine2623 self-assigned this Jul 23, 2021
@florine2623
Copy link
Contributor

Hello @Progi1984 ,

All good to me !
Thanks !

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 23, 2021
@Progi1984 Progi1984 added the Waiting for author Status: action required, waiting for author feedback label Jul 23, 2021
@Progi1984
Copy link
Contributor Author

WAIT FOR 1780 RELEASE

@marionf marionf modified the milestones: 1.7.8.0, 1.7.8.1 Jul 30, 2021
@NeOMakinG
Copy link

@Progi1984 I remember something about this, flags needed to be on the same row (as specified in the ticket), but with spaces, not on the same column, but @prestascott needs to validate it

@sowbiba sowbiba added the Waiting for UX Status: action required, waiting for design feedback label Aug 17, 2021
@Progi1984 Progi1984 removed QA ✔️ Status: check done, code approved Waiting for author Status: action required, waiting for author feedback labels Aug 23, 2021
@prestascott prestascott added UX ✔️ Status: check done, design approved and removed Waiting for UX Status: action required, waiting for design feedback labels Aug 31, 2021
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Sep 2, 2021
@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Sep 3, 2021
@florine2623
Copy link
Contributor

Hi all,

Tested again, and it works like a charm.

Thanks for the PR!

@Progi1984 Progi1984 merged commit a075bfd into PrestaShop:1.7.8.x Sep 3, 2021
@Progi1984 Progi1984 deleted the issue25272 branch September 3, 2021 14:18
@Progi1984
Copy link
Contributor Author

Thanks @florine2623

@Progi1984 Progi1984 mentioned this pull request Sep 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@sowbiba sowbiba sowbiba approved these changes

@jolelievre jolelievre jolelievre approved these changes

Assignees

@florine2623 florine2623

Labels
1.7.8.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved UX ✔️ Status: check done, design approved
Projects
None yet
Milestone
1.7.8.1
Development

Successfully merging this pull request may close these issues.

FO - the product-flags must be on the same row but with spaces
10 participants
@Progi1984 @florine2623 @NeOMakinG @PierreRambaud @matthieu-rolland @sowbiba @jolelievre @marionf @prestonBot @prestascott