Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct some typescript ignore and external libraries #25899

Merged
merged 3 commits into from
Sep 20, 2021

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Sep 15, 2021

Questions Answers
Branch? develop
Description? Some typescript lines were ignored but we could cast or use some types libraries
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? Nothing testable except that it build without errors
Possible impacts? Nothing

This change is Reviewable

@NeOMakinG NeOMakinG added this to the 8.0.0 milestone Sep 15, 2021
@NeOMakinG NeOMakinG requested a review from a team as a code owner September 15, 2021 15:29
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Sep 15, 2021
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NeOMakinG Thank you for your contribution. A small fix for CI 🔴

@matthieu-rolland
Copy link
Contributor

matthieu-rolland commented Sep 20, 2021

thank you @NeOMakinG

@matthieu-rolland matthieu-rolland merged commit 621f9fa into PrestaShop:develop Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants