Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update webpack, babel and others webpack dependencies of new-theme #25936

Merged
merged 3 commits into from
Sep 27, 2021
Merged

Update webpack, babel and others webpack dependencies of new-theme #25936

merged 3 commits into from
Sep 27, 2021

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Sep 20, 2021 •
edited by PierreRambaud
Loading

Questions Answers
Branch? develop
Description? Webpack had some updates needed
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? Can be tested by a dev, it's all about building the new-theme folder
Possible impacts? New-theme pages

This change is Reviewable

@NeOMakinG NeOMakinG added this to the 8.0.0 milestone Sep 20, 2021
@NeOMakinG NeOMakinG requested a review from a team as a code owner September 20, 2021 15:38
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Sep 20, 2021
@PrestaShop PrestaShop deleted a comment from prestonBot Sep 20, 2021
PierreRambaud
PierreRambaud previously approved these changes Sep 21, 2021
View reviewed changes
@NeOMakinG NeOMakinG added the WIP Status: Work In Progress label Sep 21, 2021
matks
matks requested changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint not happy on BO theme


Oops! Something went wrong! :(

ESLint: 7.29.0

TypeError: Cannot read property 'value' of null
Occurred while linting /home/runner/work/PrestaShop/PrestaShop/admin-dev/themes/new-theme/js/app/pages/stock/mixins/product-desc.js:29

@NeOMakinG NeOMakinG removed the WIP Status: Work In Progress label Sep 21, 2021
@NeOMakinG NeOMakinG requested review from matks, PierreRambaud and a team September 21, 2021 09:21
matthieu-rolland
matthieu-rolland approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I also tested the PR on my local environment, new-theme was built without failure 👍

@PierreRambaud PierreRambaud merged commit 8919da7 into PrestaShop:develop Sep 27, 2021
@PierreRambaud
Copy link
Contributor

Thank you @NeOMakinG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@matks matks Awaiting requested review from matks

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@NeOMakinG @PierreRambaud @matthieu-rolland @matks @prestonBot