Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selectors for Sql manager page #26120

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Fix selectors for Sql manager page #26120

merged 2 commits into from
Oct 6, 2021

Conversation

boubkerbribri
Copy link
Contributor

@boubkerbribri boubkerbribri commented Oct 5, 2021 •
edited by PierreRambaud
Loading

Questions Answers
Branch? develop
Description? Fix selectors for Sql manager page
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? UI tests are Ok, maybe re-check that export action is working as expected on Sql manager page
Possible impacts? none

This change is Reviewable

@boubkerbribri boubkerbribri added TE Category: Tests E2E Tests labels Oct 5, 2021
@boubkerbribri boubkerbribri added this to the 8.0.0 milestone Oct 5, 2021
@boubkerbribri boubkerbribri requested a review from a team as a code owner October 5, 2021 17:12
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Oct 5, 2021
@prestonBot
Copy link
Collaborator

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Oct 5, 2021
@Julievrz Julievrz added the Waiting for author Status: action required, waiting for author feedback label Oct 6, 2021
@boubkerbribri boubkerbribri removed the Waiting for author Status: action required, waiting for author feedback label Oct 6, 2021
Julievrz
Julievrz approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@Julievrz Julievrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording ✅

@Julievrz Julievrz added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Oct 6, 2021
@PierreRambaud PierreRambaud merged commit 7794806 into PrestaShop:develop Oct 6, 2021
@PierreRambaud
Copy link
Contributor

Thank you @boubkerbribri

@PierreRambaud PierreRambaud deleted the selectors/sqlManager branch October 6, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

@Julievrz Julievrz Julievrz approved these changes

Assignees
No one assigned
Labels
develop Branch E2E Tests Refactoring Type: Refactoring TE Category: Tests Wording ✔️ Status: check done, wording approved
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@boubkerbribri @prestonBot @PierreRambaud @matthieu-rolland @NeOMakinG @Julievrz