Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional Tests - Refacto Shop Parameters > Contact tests #26165

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Functional Tests - Refacto Shop Parameters > Contact tests #26165

merged 2 commits into from
Oct 11, 2021

Conversation

nesrineabdmouleh
Copy link
Contributor

@nesrineabdmouleh nesrineabdmouleh commented Oct 8, 2021 •
edited by PierreRambaud
Loading

Questions Answers
Branch? develop
Description? Refacto Shop Parameters > Contact tests
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? no need
Possible impacts? no

This change is Reviewable

@nesrineabdmouleh nesrineabdmouleh requested a review from a team as a code owner October 8, 2021 14:34
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Oct 8, 2021
@nesrineabdmouleh nesrineabdmouleh added E2E Tests TE Category: Tests labels Oct 8, 2021
@nesrineabdmouleh nesrineabdmouleh requested a review from a team October 8, 2021 14:34
@nesrineabdmouleh nesrineabdmouleh added the QA ✔️ Status: check done, code approved label Oct 11, 2021
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@nesrineabdmouleh nesrineabdmouleh added this to the 8.0.0 milestone Oct 11, 2021
@Progi1984 Progi1984 merged commit 8da483c into PrestaShop:develop Oct 11, 2021
@Progi1984
Copy link
Member

Thanks @nesrineabdmouleh

@nesrineabdmouleh nesrineabdmouleh deleted the refactoShopParametersContact branch April 6, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeOMakinG NeOMakinG NeOMakinG approved these changes

@boubkerbribri boubkerbribri boubkerbribri approved these changes

Assignees
No one assigned
Labels
develop Branch E2E Tests QA ✔️ Status: check done, code approved Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nesrineabdmouleh @prestonBot @Progi1984 @NeOMakinG @boubkerbribri