Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links to reach docs.prestashop-project.org instead of doc.prestashop.com #27150

Merged
merged 5 commits into from Feb 11, 2022
Merged

Update links to reach docs.prestashop-project.org instead of doc.prestashop.com #27150

merged 5 commits into from Feb 11, 2022

Conversation

PrestaEdit
Copy link
Contributor

@PrestaEdit PrestaEdit commented Dec 30, 2021 •
edited by MatShir

Questions Answers
Branch? 1.7.8.x
Description? Update links to docs used by the cards into Back Office.
Type? improvement
Category? BO
BC breaks? no
Fixed ticket? Fix #27493
Deprecations? no
How to test? See that helper cards have the new links used. All helper card redirect to prestashop-project.org instead of doc.prestashop.com
Possible impacts? n/d.

This change is Reviewable

@PrestaEdit PrestaEdit requested a review from a team as a code owner December 30, 2021 13:03
@prestonBot prestonBot added 1.7.8.x Branch Improvement Type: Improvement labels Dec 30, 2021
matthieu-rolland
matthieu-rolland previously approved these changes Dec 31, 2021
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ! thank you

PierreRambaud
PierreRambaud previously requested changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@PierreRambaud PierreRambaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should target the 1.7.8.x branch.
Could you please target the develop branch?

@PrestaEdit
Copy link
Contributor Author

I could, but it's specific to 1.7 version here. We will need to update again the links for develop branch.

sowbiba
sowbiba previously approved these changes Jan 7, 2022
View reviewed changes
@PierreRambaud
Copy link
Contributor

I could, but it's specific to 1.7 version here. We will need to update again the links for develop branch.

It's legit, but it hasn't been planned to integrate this in 1.7.8.4. Ping @MatShir

@MatShir
Copy link
Contributor

MatShir commented Jan 18, 2022

Nice catch, it would be nice to have it for the patch.

MatShir
MatShir requested changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@MatShir MatShir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Julievrz ping for a double check :)

MatShir
MatShir requested changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@MatShir MatShir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Julievrz ping for a double check :)

PierreRambaud
PierreRambaud previously approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@PierreRambaud PierreRambaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boss approves, I have to follow him!

@PrestaEdit PrestaEdit mentioned this pull request Jan 18, 2022
Closed
@PrestaEdit @Julievrz
Fix https (instead of hhttps)
1d07a4b 
Co-authored-by: Julie Varisellaz <70583503+Julievrz@users.noreply.github.com>
PrestaEdit and others added 2 commits January 18, 2022 11:26
@PrestaEdit @Julievrz
Update src/PrestaShopBundle/Resources/config/services/core/util/helpe…
6295462 
…r_card.yml

Co-authored-by: Julie Varisellaz <70583503+Julievrz@users.noreply.github.com>
@PrestaEdit @Julievrz
Update src/PrestaShopBundle/Resources/config/services/core/util/helpe…
39d9c98 
…r_card.yml

Co-authored-by: Julie Varisellaz <70583503+Julievrz@users.noreply.github.com>
@Julievrz
Copy link
Contributor

@Julievrz ping for a double check :)

Done ✅

MatShir
MatShir previously approved these changes Jan 18, 2022
View reviewed changes
@MatShir MatShir added the Waiting for QA Status: action required, waiting for test feedback label Jan 18, 2022
@florine2623 florine2623 self-assigned this Jan 24, 2022
@florine2623
Copy link
Contributor

Hello @PrestaEdit ,

Could you create an issue and link it in the PR please ?
Thanks!

@prestonBot
Copy link
Collaborator

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Jan 27, 2022
@PrestaEdit
Copy link
Contributor Author

I've try to add more replace but there are 5 results that can't be changed, as it was 1.6 version and not available on the doc.

Capture d’écran 2022-01-27 à 20 50 07

4

@MatShir
Copy link
Contributor

MatShir commented Jan 28, 2022

Oh nice! thanks for the extra work :)
For the rest, It looks like there is no doc as you mentionned it. I will created a dedicated issue. So with @Julievrz, we will see if we need to migrate the doc or use maybe the dev doc for some of it.
We will review your work on thuesday for a double check :)

@MatShir MatShir mentioned this pull request Jan 28, 2022
Closed
@PrestaEdit
Copy link
Contributor Author

Is the waiting for author still available ?

@MatShir MatShir removed the Waiting for author Status: action required, waiting for author feedback label Feb 2, 2022
@Robin-Fischer-PS Robin-Fischer-PS added Waiting for dev Status: action required, waiting for tech feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 2, 2022
@Robin-Fischer-PS
Copy link
Contributor

Hi,

I changed to Waiting for Dev because it needs review before getting back to QA.

@Progi1984 Progi1984 removed the Waiting for dev Status: action required, waiting for tech feedback label Feb 2, 2022
Julievrz
Julievrz approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@Julievrz Julievrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MatShir MatShir added the Waiting for QA Status: action required, waiting for test feedback label Feb 2, 2022
@Progi1984 Progi1984 added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Feb 8, 2022
@florine2623
Copy link
Contributor

Hello @PrestaEdit ,

LGTM, it is QA ✅ !

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 11, 2022
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@Progi1984 Progi1984 added this to the 1.7.8.4 milestone Feb 11, 2022
@Progi1984 Progi1984 merged commit 727ae01 into PrestaShop:1.7.8.x Feb 11, 2022
@Progi1984
Copy link
Contributor

Thanks @PrestaEdit & @florine2623

This was referenced Feb 21, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@Julievrz Julievrz Julievrz approved these changes

@MatShir MatShir MatShir left review comments

@PierreRambaud PierreRambaud Awaiting requested review from PierreRambaud

@matthieu-rolland matthieu-rolland Awaiting requested review from matthieu-rolland

@sowbiba sowbiba Awaiting requested review from sowbiba

Assignees

@florine2623 florine2623

Labels
1.7.8.x Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved Wording ✔️ Status: check done, wording approved
Projects
None yet
Milestone
1.7.8.4
Development

Successfully merging this pull request may close these issues.

Use docs.prestashop-project.org links instead of doc.prestashop.com
10 participants
@PrestaEdit @PierreRambaud @MatShir @Julievrz @florine2623 @prestonBot @Robin-Fischer-PS @Progi1984 @matthieu-rolland @sowbiba