-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FormSubmitButton selector #27228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, you can also use a function instead of an arrow function if the scope is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @atomiix
Finally, i have tested this PR after being blocked.
I checked all the related issues, they are fixed.
I checked with multistore, different image format, different langauges (as RTL) and different browsers (Chrome & Firefox)
PR27228.mp4
firefox.mp4
multistore.+.all.format.images.+.FO.result.mp4
RTL.languages.mp4
So, QA ✔️
Thanks!
Thanks @atomiix & @HanaRebaiQA |
() => {}
) for$(document).on()
which givethis
the instance of the classFormSubmitButton
and not the selector like before. This PR fixes it by usingevent.target
instead.FormSubmitButton
is used:This change is