Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate "Shop parameters > Order settings > Statuses" page #27590

Merged
merged 13 commits into from Sep 8, 2023
Merged

Migrate "Shop parameters > Order settings > Statuses" page #27590

merged 13 commits into from Sep 8, 2023

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Feb 4, 2022 •
edited

Questions Answers
Branch? develop
Description? Bye Bye Legacy & Hello Symfony
Type? refacto
Category? BO
BC breaks? yes
Deprecations? no
Fixed ticket? Resolves #10619, resolves #10620, resolves #10621, resolves #21283
How to test? This PR enables the Symfony pages for "Order States" pages

Nightly is : https://github.com/Progi1984/ga.tests.ui.pr/actions/runs/5689492000

📓 BC Breaks

  • Removed template admin-dev/themes/default/template/controllers/statuses/helpers/form/form.tpl
  • Removed class AdminStatusesController

This change is Reviewable

@Progi1984 Progi1984 requested a review from a team as a code owner February 4, 2022 14:47
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring BC break Type: Introduces a backwards-incompatible break labels Feb 4, 2022
@Progi1984 Progi1984 added this to the 8.0.0 milestone Feb 4, 2022
@Progi1984 Progi1984 changed the title Finish the migration of Order Statuses Migrate "Shop parameters > Order settings > Statuses" page Feb 4, 2022
@matks matks added the migration symfony migration project label Feb 4, 2022
NeOMakinG
NeOMakinG previously approved these changes Feb 7, 2022
View reviewed changes
matthieu-rolland
matthieu-rolland reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR needs rebase, otherwise LGTM 👍

@Progi1984 Progi1984 added the Waiting for author Status: action required, waiting for author feedback label Feb 28, 2022
@Progi1984 Progi1984 removed the Waiting for author Status: action required, waiting for author feedback label Feb 28, 2022
@Progi1984
Copy link
Contributor Author

@NeOMakinG & @matthieu-rolland Rebased

jolelievre
jolelievre requested changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I agree with the idea of this PR but it shouldn't be merged before it is fully finished You're saying in the PR's description that the modal will be added later, meaning the page is not fully migrated so it shouldn't be enabled yet

Either the modals are handled in a separate PR that needs to be merged first, or you can integrate them in this one it's ok as well But anyway the legacy page can't be removed and replaced until the new one is fully over

@Progi1984 Progi1984 added Waiting for author Status: action required, waiting for author feedback Blocked Status: The issue is blocked by another task labels Mar 1, 2022
@Progi1984
Copy link
Contributor Author

@jolelievre No soucis. I have already done a separate PR.

Blocked by #27606.

@eternoendless eternoendless added the Needs documentation Needs an update of the developer documentation label Mar 18, 2022
@Progi1984 Progi1984 mentioned this pull request Apr 5, 2022
Closed
@Hlavtox Hlavtox mentioned this pull request Apr 8, 2022
Closed
@Hlavtox
Copy link
Contributor

Hlavtox commented Apr 8, 2022

@Progi1984 Bro what is the status of this PR? There seems to be both modern and legacy code in the current develop?

@Progi1984
Copy link
Contributor Author

@Hlavtox The PR #27606 will unlock this one. Be patient. 😄

@Progi1984 Progi1984 force-pushed the issue10619 branch 2 times, most recently from 2714968 to 3d3ccbf Compare April 19, 2022 10:05
@Progi1984 Progi1984 removed Waiting for author Status: action required, waiting for author feedback Blocked Status: The issue is blocked by another task labels Apr 19, 2022
@Progi1984
Copy link
Contributor Author

@PrestaShop/committers & @hibatallahAouadni :

@prestashop-issue-bot prestashop-issue-bot bot removed the Waiting for author Status: action required, waiting for author feedback label Sep 8, 2023
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Sep 8, 2023
@MhiriFaten MhiriFaten self-assigned this Sep 8, 2023
MhiriFaten
MhiriFaten approved these changes Sep 8, 2023
View reviewed changes
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Progi1984 ,

I have checked your PR and all the old issues have been well fixed.
Automated tests are OK.
https://github.com/MhiriFaten/testing_pr/actions/runs/6122171602

It is QA approved ✔️
Thank you 🚀 💪

@MhiriFaten MhiriFaten added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Sep 8, 2023
@MatShir
Copy link
Contributor

MatShir commented Sep 8, 2023

🥳

@nicosomb nicosomb merged commit 58f13dc into PrestaShop:develop Sep 8, 2023
21 checks passed
@nicosomb
Copy link
Contributor

nicosomb commented Sep 8, 2023

Well done @Progi1984 🎉

@Progi1984 Progi1984 deleted the issue10619 branch September 8, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@boherm boherm boherm approved these changes

@boubkerbribri boubkerbribri boubkerbribri approved these changes

@MhiriFaten MhiriFaten MhiriFaten approved these changes

@NeOMakinG NeOMakinG Awaiting requested review from NeOMakinG

@atomiix atomiix Awaiting requested review from atomiix

@matthieu-rolland matthieu-rolland Awaiting requested review from matthieu-rolland

@marwachelly marwachelly Awaiting requested review from marwachelly

@Hlavtox Hlavtox Awaiting requested review from Hlavtox

@jolelievre jolelievre Awaiting requested review from jolelievre

@zuk3975 zuk3975 Awaiting requested review from zuk3975

@LouisAUTHIE LouisAUTHIE Awaiting requested review from LouisAUTHIE

@hibatallahAouadni hibatallahAouadni Awaiting requested review from hibatallahAouadni

Assignees

@MhiriFaten MhiriFaten

Labels
BC break Type: Introduces a backwards-incompatible break develop Branch migration symfony migration project Needs documentation Needs an update of the developer documentation QA ✔️ Status: check done, code approved Refactoring Type: Refactoring
Projects
PR Dashboard
Archived in project
Milestone
9.0.0