Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Add filter to hide unused order states from admin #28184

Closed
wants to merge 1 commit into from

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Apr 8, 2022

Work in progress - the actual hiding feature not implemented yet. Will be finished when #27590 is merged, because there seems to be both legacy and symfony code???

Questions Answers
Branch? develop
Description? This PR allows to hide some order states from order screen selectbox. This makes the list much shorter and easier to orientate.
Type? new feature
Category? BO
BC breaks? maybe
Deprecations? no
Fixed ticket? Fixes #14752
Related PRs -
How to test? Hide some states you don't want to use, go to order edit screen and check that they don't appear in the list. This should not affect anything other.
Possible impacts? No.

This change is Reviewable

@prestonBot prestonBot added develop Branch Feature Type: New Feature labels Apr 8, 2022
@prestonBot
Copy link
Collaborator

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Apr 8, 2022
@matks
Copy link
Contributor

matks commented Jun 14, 2022

Hi @Hlavtox this PR is in draft since April, may I suggest we close it? I'm afraid if we don't it will stay like this for some more time

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jun 14, 2022

@matks Nooo, I was waiting until the blocking PR is merged ;-)

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Sep 26, 2022

Still blocked by #27590

@ApeRunner
Copy link

So, this feature is not yet integrated in the production version of PrestaShop ?

@matks
Copy link
Contributor

matks commented Sep 12, 2023

Still blocked by #27590

@Hlavtox PR #27590 has been merged 😉

@ApeRunner No this PR has not been merged so the submitted code changes have not been added to prestashop releases

@Hlavtox Hlavtox closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Feature Type: New Feature Waiting for wording Status: action required, waiting for wording
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Idea] Allow hiding unused states from order admin selectbox
4 participants