Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid ConnectException check Webservice Endpoint #28358

Merged
merged 2 commits into from May 6, 2022
Merged

Avoid ConnectException check Webservice Endpoint #28358

merged 2 commits into from May 6, 2022

Conversation

PululuK
Copy link
Member

@PululuK PululuK commented Apr 27, 2022

Questions Answers
Branch? develop
Description? Avoid ConnectException check Webservice Endpoint
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #28357.
Related PRs IN/A
How to test? See #28357
Possible impacts? N/A

Before

Capture d’écran du 2022-04-27 18-20-18

After

image

@PululuK PululuK requested a review from a team as a code owner April 27, 2022 16:46
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Apr 27, 2022
@atomiix atomiix added the Waiting for QA Status: action required, waiting for test feedback label Apr 28, 2022
@marwachelly marwachelly self-assigned this Apr 28, 2022
@Progi1984 Progi1984 modified the milestones: 1.7.8.6, 8.0.0 May 2, 2022
marwachelly
marwachelly reviewed May 6, 2022
View reviewed changes
Copy link

@marwachelly marwachelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @PululuK,

I tested the PR. The exception is fixed and the webservice still works as expected. No regression related to the PR is detected. Tests auto are ok. So PR is QA ✔️.

Untitled_.May.5.2022.5_32.PM.mp4

Thanks,

@marwachelly marwachelly added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels May 6, 2022
@Progi1984 Progi1984 merged commit 8b883ab into PrestaShop:develop May 6, 2022
@Progi1984
Copy link
Contributor

Thanks @PululuK & @marwachelly

@PululuK PululuK deleted the catch-exception-in-checkWebserviceEndpoint branch May 6, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwachelly marwachelly marwachelly left review comments

@Progi1984 Progi1984 Progi1984 approved these changes

@kpodemski kpodemski kpodemski approved these changes

@atomiix atomiix atomiix approved these changes

@PrestaEdit PrestaEdit PrestaEdit approved these changes

Assignees

@marwachelly marwachelly

Labels
Bug fix Type: Bug fix develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

ConnectException on check Webservice Endpoint
7 participants
@PululuK @Progi1984 @kpodemski @atomiix @PrestaEdit @marwachelly @prestonBot