Fix WebserviceOutputBuilder - handle api categories blank schema #28540

angelo983 · 2022-05-19T14:32:31Z

Validation of category association id

Questions	Answers
Branch?	develop
Description?	Resolve 'Trying to access array offset on value of type null' in calling api categories blank schema
Type?	bug fix
Category?	WS
BC breaks?	no
Deprecations?	yes
Fixed ticket?	Fixes #28543
How to test?	Follow above ticket steps. Call a blank schema of Categories in a shop with Categories tree level depth > 1
Possible impacts?	Categories API

Validation of category association id

prestonBot · 2022-05-19T14:32:33Z

Hello @angelo983!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

angelo983 · 2022-05-19T15:21:56Z

Fixes #28543

matks

Dear @angelo983 thank you for the PR!

Code seems OK, just need to wait for confirmation of bug #28543

angelo983 · 2022-05-19T17:38:46Z

Hello @matks, you are welcome!
I pushed another commit covering more cases.

PululuK · 2022-05-23T12:46:36Z

classes/webservice/WebserviceOutputBuilder.php

+                            if (!empty($value['id'])) {
+                                $fields_assoc = [['id' => $value['id']]];
+                            }


Can you please use AND operator instead a new IF statement ? (see the line just bellow)

angelo983 · 2022-05-23T14:06:02Z

@PululuK I did what you asked for

AureRita · 2022-05-24T14:57:46Z

Hi @angelo983

Thank you for your PR but, currently, the issue that you want to correct didn't exist on develop and 178x, so they're already corrected, as you can see :

on 1.7.8.x :

on old develop ( 3 month ago I think ) :

on new develop ( with an other PR ) :

If you take the files from the 1.7.8.4 version, I test it and yes, it correct the issue !

angelo983 · 2022-05-24T16:54:34Z

@AureRita you replicated yourself the issue #28543.
Do you want to tell me that in version 1.7.8.6 the problem does not arise?
What number is the other PR you mentioned?

AureRita · 2022-05-25T12:26:37Z

Hi @angelo983 ,

Yes, that's it, the problem does not arise in version 1.7.8.6

I mentioned a PR that I tested near this one, if you want more information it was pr-27755

angelo983 · 2022-05-27T08:22:41Z

@AureRita in 1.7.8.6 the bug is still present, in my develop branch not because my patch is present.

AureRita · 2022-05-27T14:33:36Z

Hi @angelo983,

I do a video for you on develop without your pr :

on.develop.mp4

And another on version 1.7.8.6 :

on.1786.mp4

Can you do a video or anything else to see this problem on 1.7.8.6, it's maybe a problem with some restriction on your computer ?

Why do your webservice get blue character ?

MatShir · 2022-08-18T12:54:30Z

Hey @angelo983,
We are planning a patch release for September, it would be nice to have your fix 🚀 Could you please check last @AureRita message ?

atomiix · 2022-09-05T13:09:08Z

@angelo983 friendly reminder :)

angelo983 · 2022-09-05T14:31:52Z

Hello,
I have reproduced the problem also in 1.7.8.6 following what I wrote in #28543 issue.

I have done my part, if someone wants to go deeper could check why and how an empty value can arrive to objectAssoc when renderAssociations function is called.

matks

Hi everyone I'm lost 😅 what's happening with this pull request?

kpodemski · 2022-10-28T22:13:33Z

Hello @AureRita

You reproduced the issue before, but later you couldn't, could you please double-check if the issue is not there anymore? We have information from @angelo983 that the bug is still there.

AureRita

Hi @angelo983 !

Sorry for that long long time, after many research I see where is the differents to repeat the issue ( we need to disabled the debug mode ). After checking this, I try your PR and it's seems to works !

we can see this without your pr :

Untitled_.Oct.31.2022.2_42.PM.webm

And with your PR :

Untitled_.Oct.31.2022.2_43.PM.webm

Thank you for your Patience and your PR !

prestashop-issue-bot · 2022-10-31T13:44:37Z

QA OK without required approvals !?

prestonBot · 2022-10-31T13:44:39Z

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

jolelievre

Thanks @angelo983

jolelievre · 2022-11-02T10:07:43Z

The PR was tested and approved by QA, but it's missing one review approval (previous approvals were removed after handling a suggestion) Just waiting for the second approval to merge this one

kpodemski · 2022-11-03T12:43:47Z

Thank you @angelo983 :)

matteolavaggi · 2023-05-02T12:43:34Z

Why this bug is not fixed in PS 1.7.8.8 ?

Update WebserviceOutputBuilder.php

ac743d2

Validation of category association id

angelo983 requested a review from a team as a code owner May 19, 2022 14:32

prestonBot added the Bug fix Type: Bug fix label May 19, 2022

prestonBot added the develop Branch label May 19, 2022

matks previously approved these changes May 19, 2022

View reviewed changes

matks changed the title ~~Update WebserviceOutputBuilder.php~~ Fix WebserviceOutputBuilder - handle api categories blank schema May 19, 2022

Update WebserviceOutputBuilder.php

b788bbe

angelo983 dismissed matks’s stale review via b788bbe May 19, 2022 17:32

angelo983 mentioned this pull request May 23, 2022

'Trying to access array offset on value of type null' calling WS api categories blank schema #28543

Closed

2 tasks

Progi1984 previously approved these changes May 23, 2022

View reviewed changes

matks previously approved these changes May 23, 2022

View reviewed changes

matks added the Waiting for QA Status: action required, waiting for test feedback label May 23, 2022

PululuK reviewed May 23, 2022

View reviewed changes

Update WebserviceOutputBuilder.php

c6e8b38

angelo983 dismissed stale reviews from matks and Progi1984 via c6e8b38 May 23, 2022 14:05

AureRita self-assigned this May 24, 2022

AureRita added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels May 25, 2022

matks reviewed Sep 29, 2022

View reviewed changes

kpodemski added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for author Status: action required, waiting for author feedback labels Oct 28, 2022

AureRita approved these changes Oct 31, 2022

View reviewed changes

AureRita added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 31, 2022

Progi1984 added this to the 8.1.0 milestone Oct 31, 2022

jolelievre approved these changes Nov 2, 2022

View reviewed changes

jolelievre requested review from matks and kpodemski November 2, 2022 10:06

jolelievre requested a review from PululuK November 2, 2022 17:20

AureRita removed their assignment Nov 3, 2022

kpodemski approved these changes Nov 3, 2022

View reviewed changes

kpodemski merged commit b74ad49 into PrestaShop:develop Nov 3, 2022

angelo983 deleted the patch-1 branch November 3, 2022 13:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix WebserviceOutputBuilder - handle api categories blank schema #28540

Fix WebserviceOutputBuilder - handle api categories blank schema #28540

angelo983 commented May 19, 2022 •

edited by matks

Loading

prestonBot commented May 19, 2022

angelo983 commented May 19, 2022

matks left a comment

angelo983 commented May 19, 2022

PululuK May 23, 2022

angelo983 commented May 23, 2022

AureRita commented May 24, 2022

angelo983 commented May 24, 2022 •

edited

Loading

AureRita commented May 25, 2022

angelo983 commented May 27, 2022 •

edited

Loading

AureRita commented May 27, 2022

MatShir commented Aug 18, 2022

atomiix commented Sep 5, 2022

angelo983 commented Sep 5, 2022

matks left a comment

kpodemski commented Oct 28, 2022

AureRita left a comment

prestashop-issue-bot bot commented Oct 31, 2022

prestonBot commented Oct 31, 2022

jolelievre left a comment

jolelievre commented Nov 2, 2022

kpodemski commented Nov 3, 2022

matteolavaggi commented May 2, 2023

Fix WebserviceOutputBuilder - handle api categories blank schema #28540

Fix WebserviceOutputBuilder - handle api categories blank schema #28540

Conversation

angelo983 commented May 19, 2022 • edited by matks Loading

prestonBot commented May 19, 2022

angelo983 commented May 19, 2022

matks left a comment

Choose a reason for hiding this comment

angelo983 commented May 19, 2022

PululuK May 23, 2022

Choose a reason for hiding this comment

angelo983 commented May 23, 2022

AureRita commented May 24, 2022

angelo983 commented May 24, 2022 • edited Loading

AureRita commented May 25, 2022

angelo983 commented May 27, 2022 • edited Loading

AureRita commented May 27, 2022

MatShir commented Aug 18, 2022

atomiix commented Sep 5, 2022

angelo983 commented Sep 5, 2022

matks left a comment

Choose a reason for hiding this comment

kpodemski commented Oct 28, 2022

AureRita left a comment

Choose a reason for hiding this comment

prestashop-issue-bot bot commented Oct 31, 2022

prestonBot commented Oct 31, 2022

jolelievre left a comment

Choose a reason for hiding this comment

jolelievre commented Nov 2, 2022

kpodemski commented Nov 3, 2022

matteolavaggi commented May 2, 2023

angelo983 commented May 19, 2022 •

edited by matks

Loading

angelo983 commented May 24, 2022 •

edited

Loading

angelo983 commented May 27, 2022 •

edited

Loading