Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[+] CORE: New method Language::getIDs #2865

Merged
merged 1 commit into from
Apr 20, 2015
Merged

[+] CORE: New method Language::getIDs #2865

merged 1 commit into from
Apr 20, 2015

Conversation

gskema
Copy link
Contributor

@gskema gskema commented Apr 11, 2015

  • Most functions (maybe 70%) only need language IDs. Why grab the whole array when you only need the IDs?
  • a lot of functions could be refactored by using this new method. Some lines could even lose foreach loops.

@jnadaud jnadaud added Improvement Type: Improvement pending review labels Apr 13, 2015
@PhpMadman
Copy link
Contributor

I think this should be merged.
And as @gskema said, alot of functions can be refactored to use this new method.

jnadaud pushed a commit that referenced this pull request Apr 20, 2015
Merge pull request #2865 from gskema/lang
19194dc 
[+] CORE: New method Language::getIDs
@jnadaud jnadaud merged commit 19194dc into PrestaShop:1.6 Apr 20, 2015
@jnadaud
Copy link
Contributor

jnadaud commented Apr 20, 2015

Hi, Thank you @gskema for your contribution.

Best regards.

sfroment pushed a commit to sfroment/PrestaShop that referenced this pull request Apr 20, 2015
Merge pull request PrestaShop#2865 from gskema/lang
dc18e5a 
[+] CORE: New method Language::getIDs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Improvement Type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gskema @PhpMadman @jnadaud