Fix menu display for legacy pages #29190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeKeyCool
commented
Jul 28, 2022
MeKeyCool
commented
| Questions | Answers |
|---|---|
| Branch? | 8.0.x |
| Description? | Menu item aren't well displayed for mobile/tablet display on legacy pages. |
| Type? | bug fix |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #28863 . |
| Related PRs | |
| How to test? | Cf. #28863 ☝️ the bug happens only under mobile/tablet screen size. |
| Possible impacts? | / |
MeKeyCool
force-pushed
the
bugfix/28863_fix_menu_display_for_legacy_pages
branch
from
bff3e51
to
27a1d9d
Compare
NeOMakinG
approved these changes
Jul 28, 2022
zuk3975
approved these changes
Jul 29, 2022
zuk3975
added
the
Waiting for QA
sLorenzini
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
hello @MeKeyCool
Thank you for thi PR.
Tested on 8.0.x branch with PHP 7.3.
Legacy page links on menu in tablet and mobile screens are well displayed as Symfony pages:
legacy-links.mp4
QA approved ✅
Thanks
sLorenzini
added
QA ✔️
|
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |
|
Thank you @MeKeyCool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.