Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index.php into directory #29403

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Add index.php into directory #29403

merged 1 commit into from
Aug 23, 2022

Conversation

PrestaEdit
Copy link
Contributor

Questions Answers
Branch? develop
Description? Add missing index.php into folder.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no

@PrestaEdit PrestaEdit requested a review from a team as a code owner August 21, 2022 16:50
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Aug 21, 2022
@matks
Copy link
Contributor

matks commented Aug 22, 2022

@PrestaShop/qa-team This PR adds a missing index.php file a simple security practice followed by almost all other directories in classes. I believe it can be merged without QA as it should have no impact.

@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Aug 22, 2022
@hibatallahAouadni
Copy link
Contributor

@matks it can be merged without QA 🙂

@hibatallahAouadni hibatallahAouadni removed the Waiting for QA Status: action required, waiting for test feedback label Aug 23, 2022
@kpodemski kpodemski added this to the 8.1.0 milestone Aug 23, 2022
@kpodemski kpodemski merged commit 5be8607 into PrestaShop:develop Aug 23, 2022
@kpodemski
Copy link
Contributor

Thanks @PrestaEdit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabienPapet FabienPapet FabienPapet approved these changes

@matks matks matks approved these changes

@PululuK PululuK PululuK approved these changes

@yanmakouf yanmakouf yanmakouf approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@PrestaEdit @matks @hibatallahAouadni @kpodemski @FabienPapet @PululuK @yanmakouf @prestonBot