[*] FO : Update #PSCSX-5495 input label and input title enhancements #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inetbiz
changed the title
inetbiz
changed the title
inetbiz
changed the title
inetbiz
changed the title
|
Hi, Thanks for your contribution. The cursor on quantity field is I-beam type so the title render next to it, it's not very friendly for a most users. Even if we agree it's better for accessibility, we'd rather not add the title. Please remove it and I'll be happy to merge your PR with Best regards, |
|
All done @julienbourdeau This was much more of a learning experience for me. Learning the process to contribute. |
This was referenced Jun 24, 2021
Open
Open
This was referenced Aug 4, 2021
Open
Open
Open
Open
Open
This was referenced Sep 1, 2021
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 317 does not have a for association for the label. Line 318 input title for (WCAG 2.0) hints and accessibility devices.