Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 8.1.0 & Github Actions : Removed Skip Conditions #30087

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Bump version to 8.1.0 & Github Actions : Removed Skip Conditions #30087

merged 2 commits into from
Nov 17, 2022

Conversation

Progi1984
Copy link
Member

Questions Answers
Branch? develop
Description? Bump version to 8.1.0
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? N/A

@Progi1984 Progi1984 requested a review from a team as a code owner October 21, 2022 11:29
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Oct 21, 2022
@Progi1984 Progi1984 added this to the 8.1.0 milestone Oct 21, 2022
@Progi1984 Progi1984 mentioned this pull request Oct 21, 2022
Closed
@Progi1984 Progi1984 changed the title Bump version to 8.1.0 Set version to 8.1.0 Oct 21, 2022
@Progi1984 Progi1984 closed this Oct 21, 2022
@Progi1984 Progi1984 reopened this Oct 21, 2022
@Progi1984 Progi1984 changed the title Set version to 8.1.0 Bump version to 8.1.0 Oct 21, 2022
@Progi1984
Copy link
Member Author

@jolelievre You have right. It works now.

@kpodemski
Copy link
Contributor

@Progi1984 are you sure about these changes from .yml files? this will cause problems with dependabot again

@Progi1984
Copy link
Member Author

@kpodemski Yes i'm sure. It locks PR because it skips actions which are required. I will work on it to find a better solution.

@kpodemski
Copy link
Contributor

@Progi1984 but you could just use a different title, right?

@Progi1984 Progi1984 changed the title Bump version to 8.1.0 Bump version to 8.1.0 & Github Actions : Removed Skip Conditions Oct 27, 2022
@Progi1984 Progi1984 added the Waiting for author Status: action required, waiting for author feedback label Oct 27, 2022
@Progi1984 Progi1984 removed the Waiting for author Status: action required, waiting for author feedback label Oct 31, 2022
@Progi1984
Copy link
Member Author

@kpodemski Fixed.

@matks
Copy link
Contributor

matks commented Nov 17, 2022

Thank you @Progi1984

@matks matks merged commit 57fbb2b into PrestaShop:develop Nov 17, 2022
@Progi1984 Progi1984 deleted the bumpVersion810 branch November 17, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Progi1984 @kpodemski @matks @nicosomb @prestonBot