Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update classic theme #30113

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Conversation

jolelievre
Copy link
Contributor

Questions Answers
Branch? 8.0.x
Description? Update classic theme with 2.0.6
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? ~
Related PRs ~
How to test? ~
Possible impacts? ~

@jolelievre jolelievre requested a review from a team as a code owner October 25, 2022 14:44
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added 8.0.x Branch Bug fix Type: Bug fix labels Oct 25, 2022
@kpodemski kpodemski added this to the 8.0.0 milestone Oct 25, 2022
@kpodemski kpodemski merged commit b578f99 into PrestaShop:8.0.0-rc Oct 25, 2022
@jolelievre jolelievre deleted the update-classic branch February 1, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.0.x Branch Bug fix Type: Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants