Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not build a domain from the module name (Cherry pick of #30080) #30114

Merged
merged 1 commit into from Nov 7, 2022
Merged

Do not build a domain from the module name (Cherry pick of #30080) #30114

merged 1 commit into from Nov 7, 2022

Conversation

atomiix
Copy link
Contributor

@atomiix atomiix commented Oct 25, 2022 •
edited

Questions Answers
Branch? 1.7.8.x
Description? Cherry pick of #30080
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #30076
Related PRs #27422
How to test? Please see #30076 & #27422
Possible impacts?

@atomiix atomiix marked this pull request as ready for review October 25, 2022 15:00
@prestonBot prestonBot added the 8.0.x Branch label Oct 25, 2022
@atomiix atomiix requested a review from a team as a code owner October 25, 2022 15:00
@prestonBot prestonBot added the Bug fix Type: Bug fix label Oct 25, 2022
@prestonBot prestonBot added the 1.7.8.x Branch label Oct 25, 2022
@atomiix atomiix removed the 8.0.x Branch label Oct 25, 2022
@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Oct 27, 2022
@matks matks changed the title Do not build a domain from the module name Do not build a domain from the module name (Cherry pick of #30080) Oct 27, 2022
boubkerbribri
boubkerbribri previously requested changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@boubkerbribri boubkerbribri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an linked to php7.1 and Addons.
I don't think its linked to this PR. But CI is failing and we can't merge unless it's green.
image

@boubkerbribri boubkerbribri added Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 28, 2022
@MatShir MatShir added this to To be reviewed in PrestaShop 1.7.8.x Nov 4, 2022
@atomiix atomiix added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback labels Nov 4, 2022
@MatShir MatShir moved this from To be reviewed to To be tested in PrestaShop 1.7.8.x Nov 4, 2022
@atomiix atomiix dismissed boubkerbribri’s stale review November 4, 2022 11:16

Everything is green!

@khouloudbelguith khouloudbelguith self-assigned this Nov 4, 2022
khouloudbelguith
khouloudbelguith approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@khouloudbelguith khouloudbelguith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @atomiix,

I checked this PR, it is ok ✔️

-Check the original issue (#30076) with the same module: OK
-Check both issues (#27410 & #26549)
-Check with different module updates by adding new translations files (Arabic, Italian, Japan) : OK
-Check when the underscore is in the different positions (First position, second..., last) : OK
-Check with other natives module configuration and translations update: OK (productcomments, newslettersubscription, contact us best-selling products)
-Check the automatic tests in the translation page: OK
-Check with different translation types :

  • Back Office : OK
  • Font Office :OK
  • Email Translations (Subject + core) : OK
  • Installed modules with native modules : OK
  • Other : OK

-Check with multistore (second shop) : OK
-Check with different themes (Classic, customized themes) : OK

Theme.Logo._.Theme.PrestaShop.mp4

Thanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 7, 2022
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@khouloudbelguith khouloudbelguith moved this from To be tested to To be merged in PrestaShop 1.7.8.x Nov 7, 2022
@jolelievre
Copy link
Contributor

Thanks @atomiix and @khouloudbelguith

@jolelievre jolelievre merged commit 8681193 into PrestaShop:1.7.8.x Nov 7, 2022
PrestaShop 1.7.8.x automation moved this from To be merged to Done Nov 7, 2022
@atomiix atomiix deleted the fix/30076-178x branch November 7, 2022 13:12
@mflasquin mflasquin added this to the 1.7.8.8 milestone Nov 25, 2022
@kpodemski kpodemski mentioned this pull request Jul 27, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@FabienPapet FabienPapet FabienPapet approved these changes

@kpodemski kpodemski kpodemski approved these changes

@PrestaEdit PrestaEdit PrestaEdit approved these changes

@khouloudbelguith khouloudbelguith khouloudbelguith approved these changes

@yanmakouf yanmakouf yanmakouf approved these changes

@boubkerbribri boubkerbribri boubkerbribri left review comments

Assignees

@khouloudbelguith khouloudbelguith

Labels
1.7.8.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
PrestaShop 1.7.8.x
Done
Milestone
1.7.8.8
Development

Successfully merging this pull request may close these issues.

None yet