Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BO - Orders - Credit Slips - Sort & Pagination Credit Slips #30222

Merged
merged 15 commits into from
Nov 9, 2022
Merged

BO - Orders - Credit Slips - Sort & Pagination Credit Slips #30222

merged 15 commits into from
Nov 9, 2022

Conversation

cfarhani06
Copy link
Contributor

@cfarhani06 cfarhani06 commented Nov 4, 2022 •
edited by nesrineabdmouleh
Loading

Questions Answers
Branch? 8.0.x
Description? BO - Orders - Credit Slips - Sort & Pagination Credit Slips
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? N/A
Related PRs N/A
How to test? TEST_PATH='functional/BO/02*/03*/02*' HEADLESS='false' npm run test:specific
Possible impacts? N/A

@cfarhani06 cfarhani06 added Improvement Type: Improvement TE Category: Tests develop Branch E2E Tests labels Nov 4, 2022
@cfarhani06 cfarhani06 added this to the 8.1.0 milestone Nov 4, 2022
@cfarhani06 cfarhani06 requested review from a team November 4, 2022 16:43
@Progi1984
Copy link
Member

@cfarhani06 Thank you for your contribution. Could you fix lint errors ?

Progi1984
Progi1984 reviewed Nov 9, 2022
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment and it's an approval 🎉

@prestonBot prestonBot added the 8.0.x Branch label Nov 9, 2022
@nesrineabdmouleh nesrineabdmouleh removed the develop Branch label Nov 9, 2022
@Progi1984 Progi1984 modified the milestones: 8.1.0, 8.0.1 Nov 9, 2022
@kpodemski kpodemski requested review from a team and removed request for a team November 9, 2022 10:40
@Progi1984 Progi1984 added the QA ✔️ Status: check done, code approved label Nov 9, 2022
@boubkerbribri boubkerbribri merged commit af9f677 into PrestaShop:8.0.x Nov 9, 2022
@boubkerbribri
Copy link
Contributor

Thanks @cfarhani06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@nesrineabdmouleh nesrineabdmouleh nesrineabdmouleh approved these changes

@boubkerbribri boubkerbribri boubkerbribri approved these changes

Assignees
No one assigned
Labels
8.0.x Branch E2E Tests Improvement Type: Improvement QA ✔️ Status: check done, code approved TE Category: Tests
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@cfarhani06 @Progi1984 @boubkerbribri @nesrineabdmouleh @prestonBot