Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about customer default group #31439

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Feb 18, 2023

Questions Answers
Branch? develop
Description? Adds information about customer's default group into backoffice customer detail page. I added additional optional property into GroupInformation object, so I can use it freely in the template and I can make it non-clickable.
Type? new feature
Category? BO
BC breaks? no
Deprecations? no
How to test? Visit the page and see it works correctly.
Fixed ticket?
Related PRs
Sponsor company

group

@Hlavtox Hlavtox requested a review from a team as a code owner February 18, 2023 16:03
@prestonBot prestonBot added develop Branch Feature Type: New Feature labels Feb 18, 2023
@PrestaShop PrestaShop deleted a comment from prestonBot Feb 18, 2023
kpodemski
kpodemski previously approved these changes Feb 18, 2023
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add types, but there's no declare(strict_types=1); at the top of the file. Maybe you should add it, but I won't block it as it increases the scope of the PR.

src/Core/Domain/Customer/QueryResult/GroupInformation.php Outdated Show resolved Hide resolved
src/Core/Domain/Customer/QueryResult/GroupInformation.php Outdated Show resolved Hide resolved
Copy link
Contributor

@zuk3975 zuk3975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is ok, but PR has no issue, so can @MatShir approve this feature?

@zuk3975 zuk3975 added the Waiting for PM Status: action required, waiting for product feedback label Feb 20, 2023
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Feb 20, 2023

@MatShir There was an issue for example here - #23116, but we didn't do a design for customer detail.

I have already implemented it to:

  • ✅ Customer list
  • ✅ Order view
  • ✅ Order create

@MatShir
Copy link
Contributor

MatShir commented Feb 20, 2023

LGTM 👍

@MatShir MatShir added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for PM Status: action required, waiting for product feedback labels Feb 20, 2023
@MatShir
Copy link
Contributor

MatShir commented Feb 20, 2023

nice feature !

@MatShir
Copy link
Contributor

MatShir commented Feb 20, 2023

At some point, this page needs to be redesigned. There is some much information and possibly a lot of performance issues

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Feb 20, 2023

@MatShir I am migrating the lists to grid with pagination - #31442, will be fast for everybody now.
EDIT: you saw it

@MatShir MatShir added the PM ✔️ Status: check done, behavior approved label Feb 20, 2023
@MatShir MatShir added this to the 9.0.0 milestone Feb 20, 2023
@HanaRebaiQA HanaRebaiQA self-assigned this Feb 21, 2023
Copy link

@HanaRebaiQA HanaRebaiQA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox

I have checked your PR. the feature is well-added.

image

image

image

image

@HanaRebaiQA HanaRebaiQA added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 21, 2023
@Hlavtox Hlavtox merged commit 1ca0142 into PrestaShop:develop Feb 21, 2023
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Feb 21, 2023

Thank you @HanaRebaiQA!! :-)

@Hlavtox Hlavtox deleted the customer-view branch February 21, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Feature Type: New Feature PM ✔️ Status: check done, behavior approved QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants