-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about customer default group #31439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add types, but there's no declare(strict_types=1);
at the top of the file. Maybe you should add it, but I won't block it as it increases the scope of the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is ok, but PR has no issue, so can @MatShir approve this feature?
LGTM 👍 |
nice feature ! |
At some point, this page needs to be redesigned. There is some much information and possibly a lot of performance issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Hlavtox
I have checked your PR. the feature is well-added.
-
Check the automated tests (The failures of teh automated tests exist on the nightly develop): OK
Run PR : https://github.com/HanaRebaiQA/testing_pr/actions/runs/4230525373/jobs/7347952380
Nightly : https://github.com/PrestaShop/PrestaShop/actions/runs/4228408393 -
Check with different
Group access
combinations : OK -
Check with different
Default customer group
: OK -
Check when create a new customer group, : OK
-
Check with different languages 'RTL and no RTL) : OK
-
Check with multistore : OK
-
Check with different browsers (Chrome & Firefox) : OK
-
Check with responsive mode : OK
Thank you @HanaRebaiQA!! :-) |
GroupInformation
object, so I can use it freely in the template and I can make it non-clickable.