Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API access Command #33833

Merged
merged 1 commit into from Sep 28, 2023
Merged

Add API access Command #33833

merged 1 commit into from Sep 28, 2023

Conversation

tleon
Copy link
Contributor

@tleon tleon commented Sep 4, 2023 •
edited

Questions Answers
Branch? develop
Description? First step into implementing the api access feature. This is the add part.
Type? new feature
Category? BO
BC breaks? no
Deprecations? no
How to test? CI 🟢 & tests 🟢
Fixed issue or discussion? Fixes #33765
Sponsor company PrestaShop SA

@prestonBot prestonBot added Bug fix Type: Bug fix BC break Type: Introduces a backwards-incompatible break labels Sep 4, 2023
@tleon tleon force-pushed the Issue-33765-add-api-access-command branch 4 times, most recently from 48769cb to bfa8da3 Compare September 7, 2023 15:14
@prestonBot prestonBot added develop Branch Feature Type: New Feature labels Sep 7, 2023
@tleon tleon removed develop Branch Bug fix Type: Bug fix BC break Type: Introduces a backwards-incompatible break labels Sep 7, 2023
@PrestaShop PrestaShop deleted a comment from prestonBot Sep 7, 2023
@tleon tleon changed the title wip feat(api-access): add api access command Sep 7, 2023
@prestonBot prestonBot added the develop Branch label Sep 7, 2023
@tleon tleon force-pushed the Issue-33765-add-api-access-command branch from bfa8da3 to dc583b4 Compare September 7, 2023 15:35
@tleon tleon marked this pull request as ready for review September 7, 2023 16:04
@tleon tleon requested a review from a team as a code owner September 7, 2023 16:04
@matks matks changed the title feat(api-access): add api access command Add API access Command Sep 13, 2023
@tleon tleon force-pushed the Issue-33765-add-api-access-command branch from dc583b4 to f1c706a Compare September 20, 2023 16:11
@tleon tleon self-assigned this Sep 20, 2023
boherm
boherm previously requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@boherm boherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but just a little comment to simplify the api_access.yml file and maybe check if we could use constructor property promotion when we can!

src/PrestaShopBundle/Resources/config/services/adapter/api_access.yml Outdated Show resolved Hide resolved
@ps-jarvis ps-jarvis added the Waiting for author Status: action required, waiting for author feedback label Sep 21, 2023
jolelievre
jolelievre reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last comments and it should be good, we already handled a few together if you have questions about the others don't hesitate to ping me

src/Adapter/ApiAccess/CommandHandler/AddApiAccessHandler.php Outdated Show resolved Hide resolved
src/Adapter/ApiAccess/CommandHandler/AddApiAccessHandler.php Outdated Show resolved Hide resolved
src/Adapter/ApiAccess/CommandHandler/AddApiAccessHandler.php Outdated Show resolved Hide resolved
src/PrestaShopBundle/Entity/ApiAccess.php Show resolved Hide resolved
src/PrestaShopBundle/Entity/ApiAccess.php Outdated Show resolved Hide resolved
tests/Integration/Behaviour/Features/Context/Domain/ApiAccessManagementFeatureContext.php Outdated Show resolved Hide resolved
tests/Integration/Behaviour/Features/Context/Domain/ApiAccessManagementFeatureContext.php Outdated Show resolved Hide resolved
tests/Integration/Behaviour/Features/Context/Domain/ApiAccessManagementFeatureContext.php Outdated Show resolved Hide resolved
tests/Integration/Behaviour/Features/Scenario/ApiAccess/api_access_management.feature Outdated Show resolved Hide resolved
tests/Integration/Behaviour/Features/Scenario/ApiAccess/api_access_management.feature Outdated Show resolved Hide resolved
@tleon tleon force-pushed the Issue-33765-add-api-access-command branch 3 times, most recently from c3807aa to 75e8c2a Compare September 22, 2023 14:58
@tleon tleon force-pushed the Issue-33765-add-api-access-command branch 2 times, most recently from b27b9ab to 307a21e Compare September 28, 2023 14:28
@tleon tleon force-pushed the Issue-33765-add-api-access-command branch from 307a21e to 4ee2ab0 Compare September 28, 2023 14:43
jolelievre
jolelievre reviewed Sep 28, 2023
View reviewed changes
src/Core/Domain/ApiAccess/Command/EditApiAccessCommand.php Outdated Show resolved Hide resolved
src/Core/Domain/ApiAccess/Exception/ApiAccessConstraintException.php Outdated Show resolved Hide resolved
src/Adapter/ApiAccess/CommandHandler/AddApiAccessHandler.php Outdated Show resolved Hide resolved
src/Adapter/ApiAccess/CommandHandler/EditApiAccessHandler.php Outdated Show resolved Hide resolved
src/PrestaShopBundle/Entity/ApiAccess.php Outdated Show resolved Hide resolved
src/PrestaShopBundle/Entity/ApiAccess.php Outdated Show resolved Hide resolved
src/PrestaShopBundle/Entity/ApiAccess.php Outdated Show resolved Hide resolved
tests/Integration/Behaviour/Features/Context/Domain/ApiAccessManagementFeatureContext.php Outdated Show resolved Hide resolved
@tleon tleon force-pushed the Issue-33765-add-api-access-command branch from 4ee2ab0 to 2ca8686 Compare September 28, 2023 15:30
@tleon tleon force-pushed the Issue-33765-add-api-access-command branch 4 times, most recently from f549167 to 20a430b Compare September 28, 2023 15:58
jolelievre
jolelievre previously approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tleon

src/PrestaShopBundle/Entity/ApiAccess.php Outdated Show resolved Hide resolved
@tleon tleon force-pushed the Issue-33765-add-api-access-command branch from 20a430b to b1b658a Compare September 28, 2023 16:06
matks
matks previously approved these changes Sep 28, 2023
View reviewed changes
jolelievre
jolelievre previously approved these changes Sep 28, 2023
View reviewed changes
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Sep 28, 2023
@hibatallahAouadni
Copy link
Contributor

This PR will be QAed by a dev or by a QA? :trollface:

@jolelievre
Copy link
Contributor

This PR will be QAed by a dev or by a QA? :trollface:

@hibatallahAouadni QAed by computer for this one 😛

@tleon tleon dismissed stale reviews from jolelievre and matks via 122312b September 28, 2023 16:19
@tleon tleon force-pushed the Issue-33765-add-api-access-command branch from b1b658a to 122312b Compare September 28, 2023 16:19
@jolelievre jolelievre merged commit 794ea43 into PrestaShop:develop Sep 28, 2023
18 checks passed
@hibatallahAouadni hibatallahAouadni removed the Waiting for QA Status: action required, waiting for test feedback label Sep 28, 2023
@Progi1984 Progi1984 added this to the 9.0.0 milestone Sep 29, 2023
@tleon tleon mentioned this pull request Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@jolelievre jolelievre jolelievre approved these changes

@boherm boherm Awaiting requested review from boherm

@nicosomb nicosomb Awaiting requested review from nicosomb

Assignees

@tleon tleon

Labels
develop Branch Feature Type: New Feature
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
10 participants
@tleon @hibatallahAouadni @jolelievre @nicosomb @matks @boherm @Progi1984 @ps-jarvis @prestonBot @MatShir