Fix(authServ): repair auth server page in BO #34106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tleon
commented
Sep 29, 2023
•
tleon
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | A field in the ApiAccess entity has been renamed in another PR. The experimental BO page was broken because of this change. This PR fixes this. |
| Type? | bug fix |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | Activate the experimental Auth Server page. Then access it. |
| UI Tests | https://github.com/tleon/ga.tests.ui.pr/actions/runs/6353483501 |
| Related PRs | #33833 |
| Sponsor company | PrestaShop SA |
|
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! About linked issuesPlease consider opening an issue before submitting a Pull Request:
(Note: this is an automated message, but answering it will reach a real human) |
nicosomb
previously approved these changes
Sep 29, 2023
matthieu-rolland
previously approved these changes
Sep 29, 2023
ps-jarvis
added
the
Waiting for QA
jolelievre
previously approved these changes
Sep 29, 2023
tleon
dismissed stale reviews from jolelievre, matthieu-rolland, and nicosomb
via
f0a53be
tleon
force-pushed
the
Issue-33765-fix-auth-server-page
branch
from
228b28f
to
f0a53be
Compare
nicosomb
previously approved these changes
Sep 29, 2023
jolelievre
changed the title
jolelievre
previously approved these changes
Sep 29, 2023
tleon
force-pushed
the
Issue-33765-fix-auth-server-page
branch
from
f0a53be
to
ace7709
Compare
boherm
previously approved these changes
Sep 29, 2023
Progi1984
previously approved these changes
Sep 29, 2023
PululuK
previously approved these changes
Sep 29, 2023
tleon
force-pushed
the
Issue-33765-fix-auth-server-page
branch
2 times, most recently
from
c386cce
to
5e9be28
Compare
boherm
previously approved these changes
Oct 2, 2023
|
Hello @tleon Thank you for your PR, I tried it and unfortunately, I can't go on auth serv when I install your PR as you can see : Untitled_.Oct.2.2023.3_07.PM.webmWaiting for your feedback |
AureRita
added
the
Waiting for author
tleon
force-pushed
the
Issue-33765-fix-auth-server-page
branch
from
5e9be28
to
32d1d1e
Compare
jolelievre
approved these changes
Oct 2, 2023
jolelievre
reviewed
Oct 2, 2023
| @@ -108,10 +108,9 @@ private function applyAssociatedQueries(QueryBuilder $queryBuilder): void | |||
| private function appendActiveApiAccessQuery(QueryBuilder $queryBuilder): void | |||
| { | |||
| $shopQueryBuilder = $this->getQueryBuilder() | |||
| ->select('count(api.active)') | |||
| ->select('count(api.enabled)') | |||
There was a problem hiding this comment.
Suggested change
| ->select('count(api.enabled)') | |
| ->select('count(api.id_api_access)') |
Seems like it makes more sense to test the count of IDs no? Like in the other method
| ->from($this->dbPrefix . 'api_access', 'api') | ||
| ->where('api.id_authorized_application = aa.id_authorized_application') | ||
| ->andWhere('api.active = 1'); | ||
| ->Where('api.enabled = 1'); |
There was a problem hiding this comment.
You removed this condition because the relationship has been removed in the ApiAccess entity right? This changes the behavior of the grid, but it's supposed to be completely removed soon anyway so as long as tests do not shout I guess we don't really care
|
Closed in favor of #34146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.