Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get a list of unique module's name #34029

Merged
merged 2 commits into from Oct 23, 2023
Merged

Get a list of unique module's name #34029

merged 2 commits into from Oct 23, 2023

Conversation

PrestaEdit
Copy link
Contributor

Questions Answers
Branch? develop
Description? Get a list of unique module's name to avoid a slower foreach on theme translations.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? See issue
UI Tests n/d
Fixed issue or discussion? Fixes #34028
Sponsor company @wepika

@PrestaEdit PrestaEdit requested a review from a team as a code owner September 22, 2023 07:41
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Sep 22, 2023
boherm
boherm reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@boherm boherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @PrestaEdit!
Just a little comment to discuss together, but I globally agree with this. 🙂

src/Core/Translation/Storage/Provider/ThemeCatalogueLayersProvider.php Outdated Show resolved Hide resolved
matthieu-rolland
matthieu-rolland reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once @boherm 's feedback is applied it's lgtm for me 👍

boherm
boherm approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@boherm boherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now, thanks @PrestaEdit!

@M0rgan01 M0rgan01 assigned M0rgan01 and unassigned M0rgan01 Sep 27, 2023
@M0rgan01 M0rgan01 added the Waiting for QA Status: action required, waiting for test feedback label Sep 27, 2023
@hibatallahAouadni hibatallahAouadni added Waiting for dev Status: action required, waiting for tech feedback Waiting for PM Status: action required, waiting for product feedback and removed Waiting for QA Status: action required, waiting for test feedback Waiting for dev Status: action required, waiting for tech feedback labels Sep 28, 2023
@hibatallahAouadni
Copy link
Contributor

Waiting for PM to confirm the expected behavior (see comment).

@PrestaEdit
Copy link
Contributor Author

Any update on this ?

It's 25 days without move.

@kpodemski kpodemski added PM ✔️ Status: check done, behavior approved and removed Waiting for PM Status: action required, waiting for product feedback labels Oct 23, 2023
@kpodemski
Copy link
Contributor

thanks @PrestaEdit

I also validated the PR, and the translations work as expected.

@kpodemski kpodemski added this to the 9.0.0 milestone Oct 23, 2023
@kpodemski kpodemski merged commit ce53c89 into PrestaShop:develop Oct 23, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

@boherm boherm boherm approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

@LouisAUTHIE LouisAUTHIE LouisAUTHIE approved these changes

@matthieu-rolland matthieu-rolland Awaiting requested review from matthieu-rolland

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement PM ✔️ Status: check done, behavior approved
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Multiple domains inside modules translations will slower the theme translations
8 participants
@PrestaEdit @hibatallahAouadni @kpodemski @matthieu-rolland @boherm @M0rgan01 @LouisAUTHIE @prestonBot